[region-isolation] Add support for strong_copy_unmanaged_value.

I also made ref_to_unmanaged and unmanaged_to_ref look through. They should have
always been look through, but I believe early on they were marked assign and I
never touched fixed it. To get the test for strong_copy_unmanaged_value to work,
I needed them to obey these semantics so I fixed them at the same time.

Author: gottesmm

lib/SILOptimizer/Analysis/RegionAnalysis.cpp

@@ -225,6 +225,9 @@ static bool isStaticallyLookThroughInst(SILInstruction *inst) {
   case SILInstructionKind::ValueToBridgeObjectInst:
   case SILInstructionKind::WeakCopyValueInst:
   case SILInstructionKind::StrongCopyWeakValueInst:
+  case SILInstructionKind::StrongCopyUnmanagedValueInst:
+  case SILInstructionKind::RefToUnmanagedInst:
+  case SILInstructionKind::UnmanagedToRefInst:
     return true;
   case SILInstructionKind::UnconditionalCheckedCastInst: {
     auto cast = SILDynamicCastInst::getAs(inst);
@@ -2285,14 +2288,12 @@ CONSTANT_TRANSLATION(InitExistentialAddrInst, Assign)
 CONSTANT_TRANSLATION(InitExistentialRefInst, Assign)
 CONSTANT_TRANSLATION(OpenExistentialBoxInst, Assign)
 CONSTANT_TRANSLATION(OpenExistentialRefInst, Assign)
-CONSTANT_TRANSLATION(RefToUnmanagedInst, Assign)
 CONSTANT_TRANSLATION(TailAddrInst, Assign)
 CONSTANT_TRANSLATION(ThickToObjCMetatypeInst, Assign)
 CONSTANT_TRANSLATION(ThinToThickFunctionInst, Assign)
 CONSTANT_TRANSLATION(UncheckedAddrCastInst, Assign)
 CONSTANT_TRANSLATION(UncheckedEnumDataInst, Assign)
 CONSTANT_TRANSLATION(UncheckedOwnershipConversionInst, Assign)
-CONSTANT_TRANSLATION(UnmanagedToRefInst, Assign)
 CONSTANT_TRANSLATION(IndexRawPointerInst, Assign)
 
 // These are used by SIL to aggregate values together in a gep like way. We
@@ -2346,6 +2347,9 @@ CONSTANT_TRANSLATION(BeginCOWMutationInst, LookThrough)
 CONSTANT_TRANSLATION(OpenExistentialValueInst, LookThrough)
 CONSTANT_TRANSLATION(WeakCopyValueInst, LookThrough)
 CONSTANT_TRANSLATION(StrongCopyWeakValueInst, LookThrough)
+CONSTANT_TRANSLATION(StrongCopyUnmanagedValueInst, LookThrough)
+CONSTANT_TRANSLATION(RefToUnmanagedInst, LookThrough)
+CONSTANT_TRANSLATION(UnmanagedToRefInst, LookThrough)
 
 //===---
 // Store
@@ -2477,7 +2481,6 @@ CONSTANT_TRANSLATION(DeallocExistentialBoxInst, Ignored)
 // Unhandled Instructions
 //
 
-CONSTANT_TRANSLATION(StrongCopyUnmanagedValueInst, Unhandled)
 CONSTANT_TRANSLATION(InitExistentialValueInst, Unhandled)
 
 //===---

test/Concurrency/transfernonsendable_instruction_matching.sil

@@ -22,6 +22,7 @@ class NonSendableKlass {}
 sil @transferNonSendableKlass : $@convention(thin) @async (@guaranteed NonSendableKlass) -> ()
 sil @useNonSendableKlass : $@convention(thin) (@guaranteed NonSendableKlass) -> ()
 sil @constructNonSendableKlass : $@convention(thin) () -> @owned NonSendableKlass
+sil @useUnmanagedNonSendableKlass : $@convention(thin) (@guaranteed @sil_unmanaged NonSendableKlass) -> ()
 
 final class SendableKlass : Sendable {}
 
@@ -1602,6 +1603,27 @@ bb0:
   destroy_value %b : $NonSendableKlass
   destroy_value %value : $NonSendableKlass
   dealloc_stack %a : $*@sil_unowned NonSendableKlass
+  %9999 = tuple ()
+  return %9999 : $()
+}
+
+sil [ossa] @strong_copy_unmanaged_value_test : $@async @convention(thin) () -> () {
+bb0:
+  %constructFn = function_ref @constructNonSendableKlass : $@convention(thin) () -> @owned NonSendableKlass
+  %value = apply %constructFn() : $@convention(thin) () -> @owned NonSendableKlass
+
+  %transferNonSendableKlass = function_ref @transferNonSendableKlass : $@convention(thin) @async (@guaranteed NonSendableKlass) -> ()
+  apply [caller_isolation=nonisolated] [callee_isolation=global_actor] %transferNonSendableKlass(%value) : $@convention(thin) @async (@guaranteed NonSendableKlass) -> () // expected-warning {{transferring value of non-Sendable type 'NonSendableKlass' from nonisolated context to global actor '<null>'-isolated context}}
+
+  %borrowedValue = begin_borrow %value : $NonSendableKlass
+  %v = ref_to_unmanaged %borrowedValue : $NonSendableKlass to $@sil_unmanaged NonSendableKlass
+  %v2 = unmanaged_to_ref %v : $@sil_unmanaged NonSendableKlass to $ NonSendableKlass
+  %v3 = ref_to_unmanaged %v2 : $NonSendableKlass to $@sil_unmanaged NonSendableKlass
+  %useFunc = function_ref @useUnmanagedNonSendableKlass : $@convention(thin) (@guaranteed @sil_unmanaged NonSendableKlass) -> ()
+  apply %useFunc(%v3) : $@convention(thin) (@guaranteed @sil_unmanaged NonSendableKlass) -> () // expected-note {{access here could race}}
+  end_borrow %borrowedValue : $NonSendableKlass
+  destroy_value %value : $NonSendableKlass
+
   %9999 = tuple ()
   return %9999 : $()
 }