no forward reference from local funcdecl

Author: hamishknight

.github/CODEOWNERS

@@ -82,11 +82,11 @@
 /include/swift/AST/DiagnosticsClangImporter.def    @egorzhdan @beccadax @ian-twilightcoder @Xazax-hun @j-hui @susmonteiro
 /include/swift/AST/DiagnosticsDriver.def           @artemcm
 /include/swift/AST/DiagnosticsFrontend.def         @artemcm @tshortli
-/include/swift/AST/DiagnosticsIDE.def              @bnbarham @hamishknight @rintaro
+/include/swift/AST/DiagnosticsIDE.def              @hamishknight @rintaro
 /include/swift/AST/DiagnosticsIRGen.def            @rjmccall
 /include/swift/AST/DiagnosticsModuleDiffer.def     @nkcsgexi
-/include/swift/AST/DiagnosticsParse.def            @bnbarham @CodaFi @DougGregor @hamishknight @rintaro
-/include/swift/AST/DiagnosticsRefactoring.def      @bnbarham @hamishknight @rintaro
+/include/swift/AST/DiagnosticsParse.def            @CodaFi @DougGregor @hamishknight @rintaro
+/include/swift/AST/DiagnosticsRefactoring.def      @hamishknight @rintaro
 /include/swift/AST/DiagnosticsSIL.def              @jckarter
 /include/swift/AST/Evaluator*                      @CodaFi @slavapestov
 /include/swift/Basic/                              @DougGregor
@@ -95,21 +95,21 @@
 /include/swift/DependencyScan                      @artemcm @cachemeifyoucan
 /include/swift/Driver*/                            @artemcm
 /include/swift/Frontend*/                          @artemcm @tshortli
-/include/swift/IDE/                                @bnbarham @hamishknight @rintaro
+/include/swift/IDE/                                @hamishknight @rintaro
 /include/swift/IRGen/                              @rjmccall
-/include/swift/Index/                              @bnbarham @hamishknight @rintaro
+/include/swift/Index/                              @hamishknight @rintaro
 /include/swift/Markup/                             @nkcsgexi
 /include/swift/Migrator/                           @nkcsgexi
 /include/swift/Option/*Options*                    @tshortli
-/include/swift/Parse/                              @bnbarham @CodaFi @DougGregor @hamishknight @rintaro
+/include/swift/Parse/                              @CodaFi @DougGregor @hamishknight @rintaro
 /include/swift/PrintAsClang                        @egorzhdan @Xazax-hun @j-hui @susmonteiro
-/include/swift/Refactoring                         @bnbarham @hamishknight @rintaro
+/include/swift/Refactoring                         @hamishknight @rintaro
 /include/swift/Runtime/                            @rjmccall @compnerd
 /include/swift/SIL/                                @jckarter
-/include/swift/SIL/*Coverage*                      @bnbarham @hamishknight @rintaro
+/include/swift/SIL/*Coverage*                      @hamishknight @rintaro
 /include/swift/SIL/*DebugInfo*                     @adrian-prantl
 /include/swift/SIL/SILDebug*                       @adrian-prantl
-/include/swift/SIL/SILProfiler.h                   @bnbarham @hamishknight @rintaro
+/include/swift/SIL/SILProfiler.h                   @hamishknight @rintaro
 /include/swift/SILOptimizer/                       @eeckstein
 /include/swift/SILOptimizer/Utils/Distributed*     @ktoso
 /include/swift/Sema/                               @hborla @slavapestov @xedin
@@ -134,7 +134,7 @@
 /lib/AST/Evaluator*                                 @CodaFi @slavapestov
 /lib/AST/ModuleLoader.cpp                           @artemcm
 /lib/AST/RequirementMachine/                        @slavapestov
-/lib/ASTGen/                                        @bnbarham @CodaFi @hamishknight @rintaro
+/lib/ASTGen/                                        @CodaFi @hamishknight @rintaro
 /lib/Basic/                                         @DougGregor
 /lib/Basic/Windows                                  @compnerd
 /lib/ClangImporter                                  @egorzhdan @beccadax @ian-twilightcoder @Xazax-hun @j-hui @susmonteiro
@@ -146,25 +146,25 @@
 /lib/DriverTool/sil_opt*                            @eeckstein
 /lib/DriverTool/swift_symbolgraph_extract_main.cpp  @QuietMisdreavus
 /lib/Frontend*/                                     @artemcm @tshortli
-/lib/IDE/                                           @bnbarham @hamishknight @rintaro
-/lib/IDETool/                                       @bnbarham @hamishknight @rintaro
+/lib/IDE/                                           @hamishknight @rintaro
+/lib/IDETool/                                       @hamishknight @rintaro
 /lib/IRGen/                                         @rjmccall
-/lib/IRGen/*Coverage*                               @bnbarham @hamishknight @rintaro
+/lib/IRGen/*Coverage*                               @hamishknight @rintaro
 /lib/IRGen/*Debug*                                  @adrian-prantl
 /lib/IRGen/*Distributed*                            @ktoso
-/lib/Index/                                         @bnbarham @hamishknight @rintaro
+/lib/Index/                                         @hamishknight @rintaro
 /lib/Macros/Sources/SwiftMacros/Swiftify*           @hnrklssn @Xazax-hun
 /lib/Markup/                                        @nkcsgexi
 /lib/Migrator/                                      @nkcsgexi
-/lib/Parse/                                         @bnbarham @CodaFi @DougGregor @hamishknight @rintaro
+/lib/Parse/                                         @CodaFi @DougGregor @hamishknight @rintaro
 /lib/PrintAsClang                                   @egorzhdan @Xazax-hun @j-hui @susmonteiro
-/lib/Refactoring/                                   @bnbarham @hamishknight @rintaro
+/lib/Refactoring/                                   @hamishknight @rintaro
 /lib/SIL/                                           @jckarter
 /lib/SIL/**/*DebugInfo*                             @adrian-prantl
-/lib/SIL/IR/*Coverage*                              @bnbarham @hamishknight @rintaro
+/lib/SIL/IR/*Coverage*                              @hamishknight @rintaro
 /lib/SIL/IR/SILDebug*                               @adrian-prantl
 /lib/SIL/IR/SILLocation*                            @adrian-prantl
-/lib/SIL/IR/SILProfiler.cpp                         @bnbarham @hamishknight @rintaro
+/lib/SIL/IR/SILProfiler.cpp                         @hamishknight @rintaro
 /lib/SILGen/                                        @jckarter @kavon
 /lib/SILGen/*Availability*                          @tshortli
 /lib/SILGen/*Distributed*                           @ktoso
@@ -218,7 +218,7 @@
 # test
 /test/*Demangl*/                                    @rjmccall
 /test/Availability/                                 @tshortli
-/test/ASTGen/                                       @bnbarham @CodaFi @hamishknight @rintaro
+/test/ASTGen/                                       @CodaFi @hamishknight @rintaro
 /test/AutoDiff/                                     @asl
 /test/Concurrency/                                  @ktoso
 /test/Constraints/                                  @hborla @xedin
@@ -229,14 +229,14 @@
 /test/Frontend/                                     @artemcm @tshortli
 /test/Generics/                                     @hborla @slavapestov
 /test/Generics/inverse*                             @kavon
-/test/IDE/                                          @bnbarham @hamishknight @rintaro
+/test/IDE/                                          @hamishknight @rintaro
 /test/IRGen/                                        @rjmccall
-/test/Index/                                        @bnbarham @hamishknight @rintaro
+/test/Index/                                        @hamishknight @rintaro
 /test/Interop/                                      @egorzhdan @Xazax-hun @j-hui @susmonteiro @hnrklssn
 /test/Macros/SwiftifyImport                         @hnrklssn @Xazax-hun
 /test/Migrator/                                     @nkcsgexi
-/test/Parse/                                        @bnbarham @CodaFi @DougGregor @hamishknight @rintaro
-/test/Profiler                                      @bnbarham @hamishknight @rintaro
+/test/Parse/                                        @CodaFi @DougGregor @hamishknight @rintaro
+/test/Profiler                                      @hamishknight @rintaro
 /test/Reflection/                                   @slavapestov
 /test/Runtime/                                      @rjmccall
 /test/SIL/                                          @jckarter
@@ -248,15 +248,15 @@
 /test/Sema/                                         @hborla @slavapestov @xedin
 /test/Sema/moveonly*                                @kavon
 /test/Serialization/                                @xymus
-/test/SourceKit/                                    @bnbarham @hamishknight @rintaro
+/test/SourceKit/                                    @hamishknight @rintaro
 /test/SymbolGraph/                                  @QuietMisdreavus
 /test/abi/                                          @swiftlang/standard-librarians
 /test/decl/                                         @hborla @slavapestov
 /test/decl/protocol/                                @AnthonyLatsis @hborla @slavapestov
 # FIXME: This file could have a dedicated directory.
 /test/decl/protocol/special/DistributedActor.swift  @ktoso
 /test/expr/                                         @hborla @slavapestov @xedin
-/test/refactoring/                                  @bnbarham @hamishknight @rintaro
+/test/refactoring/                                  @hamishknight @rintaro
 /test/sil*                                          @jckarter
 /test/sil-opt*                                      @eeckstein
 /test/stdlib/                                       @swiftlang/standard-librarians
@@ -266,25 +266,25 @@
 # tools
 # TODO: /tools
 /tools/*reflection/                                 @slavapestov
-/tools/SourceKit                                    @bnbarham @hamishknight @rintaro
+/tools/SourceKit                                    @hamishknight @rintaro
 /tools/driver/                                      @artemcm
 /tools/lldb-moduleimport-test/                      @adrian-prantl
 /tools/swift-demangle*                              @rjmccall
-/tools/swift-ide-test                               @bnbarham @hamishknight @rintaro
+/tools/swift-ide-test                               @hamishknight @rintaro
 /tools/swift-inspect                                @mikeash @al45tair @compnerd
-/tools/swift-refactor                               @bnbarham @hamishknight @rintaro
+/tools/swift-refactor                               @hamishknight @rintaro
 
 # unittests
 /unittests/*Demangl*/                     @rjmccall
 /unittests/AST/                           @hborla @slavapestov @xedin
 /unittests/AST/*Evaluator*                @CodaFi @slavapestov
 /unittests/DependencyScan/                @artemcm @cachemeifyoucan
 /unittests/Frontend*/                     @artemcm @tshortli
-/unittests/Parse/                         @bnbarham @CodaFi @DougGregor @hamishknight @rintaro
+/unittests/Parse/                         @CodaFi @DougGregor @hamishknight @rintaro
 /unittests/Reflection/                    @slavapestov
 /unittests/SIL/                           @jckarter
 /unittests/Sema/                          @hborla @xedin
-/unittests/SourceKit/                     @bnbarham @rintaro @hamishknight
+/unittests/SourceKit/                     @rintaro @hamishknight
 /unittests/runtime/                       @rjmccall
 
 # userdocs
@@ -294,34 +294,34 @@
 /utils/*windows*                                              @compnerd
 /utils/availability-macros.def                                @swiftlang/standard-librarians
 /utils/build.ps1                                              @compnerd
-/utils/build_swift/                                           @etcwilde @justice-adams-apple @shahmishal
+/utils/build_swift/                                           @etcwilde @justice-adams-apple @shahmishal @edymtt
 /utils/generate-xcode                                         @hamishknight
 /utils/gen-unicode-data                                       @swiftlang/standard-librarians
 /utils/gyb                                                    @swiftlang/standard-librarians
 /utils/gyb_foundation_support.py                              @swiftlang/standard-librarians
-/utils/gyb_sourcekit_support/                                 @bnbarham @hamishknight @rintaro
+/utils/gyb_sourcekit_support/                                 @hamishknight @rintaro
 /utils/gyb_stdlib_support.py                                  @swiftlang/standard-librarians
 /utils/gyb.py                                                 @swiftlang/standard-librarians
-/utils/sourcekit_fuzzer/                                      @bnbarham @hamishknight @rintaro
+/utils/sourcekit_fuzzer/                                      @hamishknight @rintaro
 /utils/swift-xcodegen/                                        @hamishknight
-/utils/swift_build_support/                                   @etcwilde @justice-adams-apple @shahmishal
-/utils/swift_build_support/products/earlyswiftsyntax.py       @bnbarham @hamishknight @rintaro
-/utils/swift_build_support/products/skstresstester.py         @bnbarham @hamishknight @rintaro
-/utils/swift_build_support/products/sourcekitlsp.py           @bnbarham @hamishknight @rintaro
-/utils/swift_build_support/products/swiftformat.py            @allevato @bnbarham @hamishknight @rintaro
-/utils/swift_build_support/products/swiftsyntax.py            @bnbarham @hamishknight @rintaro
-/utils/swift_build_support/products/wasm*                     @bnbarham @MaxDesiatov @kateinoigakukun
-/utils/swift_build_support/products/wasi*                     @bnbarham @MaxDesiatov @kateinoigakukun
+/utils/swift_build_support/                                   @etcwilde @justice-adams-apple @shahmishal @edymtt
+/utils/swift_build_support/products/earlyswiftsyntax.py       @hamishknight @rintaro
+/utils/swift_build_support/products/skstresstester.py         @hamishknight @rintaro
+/utils/swift_build_support/products/sourcekitlsp.py           @hamishknight @rintaro
+/utils/swift_build_support/products/swiftformat.py            @allevato @hamishknight @rintaro
+/utils/swift_build_support/products/swiftsyntax.py            @hamishknight @rintaro
+/utils/swift_build_support/products/wasm*                     @MaxDesiatov @kateinoigakukun
+/utils/swift_build_support/products/wasi*                     @MaxDesiatov @kateinoigakukun
 /utils/update-checkout*                                       @etcwilde @justice-adams-apple @shahmishal
 /utils/update_checkout/                                       @etcwilde @justice-adams-apple @shahmishal
 /utils/update_checkout/update-checkout-config.json            @shahmishal
 /utils/vim/                                                   @compnerd
 
 # validation-test
 /validation-test/Driver/                  @artemcm
-/validation-test/IDE/                     @bnbarham @rintaro @hamishknight
+/validation-test/IDE/                     @rintaro @hamishknight
 /validation-test/IRGen/                   @rjmccall
-/validation-test/Parse/                   @bnbarham @CodaFi @DougGregor @hamishknight @rintaro
+/validation-test/Parse/                   @CodaFi @DougGregor @hamishknight @rintaro
 /validation-test/Reflection/              @slavapestov
 /validation-test/Runtime/                 @rjmccall
 /validation-test/SIL/                     @jckarter

CMakeLists.txt

@@ -776,6 +776,10 @@ option(SWIFT_STDLIB_ENABLE_STRICT_CONCURRENCY_COMPLETE
   "Build the stdlib with -strict-concurrency=complete"
   FALSE)
 
+option(SWIFT_STDLIB_ENABLE_SIL_OPAQUE_VALUES
+  "Build the stdlib with -enable-sil-opaque-values"
+  FALSE)
+
 option(SWIFT_ENABLE_SYNCHRONIZATION
   "Enable build of the Swift Synchronization module"
   FALSE)

Runtimes/Core/CMakeLists.txt

@@ -106,11 +106,11 @@ defaulted_option(SwiftCore_ENABLE_RUNTIME_OS_VERSIONING "Enable runtime OS versi
 defaulted_option(SwiftCore_ENABLE_STATIC_PRINT "Disable full print")
 defaulted_option(SwiftCore_ENABLE_COMPACT_ABSOLUTE_FUNCTION_POINTERS "Resolve absolute function pointer as identity")
 defaulted_option(SwiftCore_ENABLE_BACKDEPLOYMENT_SUPPORT "Add symbols for runtime backdeployment")
-defaulted_option(SwiftCore_ENABLE_STDLIB_TRACING "Enable tracing in the runtime. Assumes the presence of os_log(3) and the os_signpost(3) API.")
 defaulted_option(SwiftCore_ENABLE_CONCURRENCY "Enable Concurrency runtime support")
 defaulted_option(SwiftCore_ENABLE_REMOTE_MIRROR "Enable RemoteMirror runtime support")
 defaulted_option(SwiftCore_ENABLE_DIRECT_RETAIN_RELEASE "Use direct retain release in the runtime/stdlib")
 defaulted_set(SwiftCore_CONCURRENCY_GLOBAL_EXECUTOR STRING "Default Concurrency global executor implementation")
+option(SwiftCore_ENABLE_STDLIB_TRACING "Enable tracing in the runtime. Requires os_log(3) and the os_signpost(3) API." OFF)
 option(SwiftCore_ENABLE_COMMANDLINE_SUPPORT "Enable command line argument support" ON)
 option(SwiftCore_ENABLE_UNICODE_DATA "Include unicode data in Swift runtimes" ON)
 option(SwiftCore_ENABLE_SHORT_MANGLING_LOOKUPS "Build with fast-path context descriptor lookups based on well-known short manglings." ON)

Runtimes/Core/Concurrency/CMakeLists.txt

@@ -22,7 +22,6 @@ add_library(swift_Concurrency
   TaskLocal.cpp
   TaskStatus.cpp
   ThreadingError.cpp
-  TracingSignpost.cpp
   "${PROJECT_SOURCE_DIR}/CompatibilityOverride/CompatibilityOverride.cpp"
   "./linker-support/magic-symbols-for-install-name.c"
   Actor.swift
@@ -99,6 +98,13 @@ add_library(swift_Concurrency
   "${CMAKE_CURRENT_BINARY_DIR}/TaskGroup+addTask.swift"
   "${CMAKE_CURRENT_BINARY_DIR}/Task+immediate.swift")
 
+if(SwiftCore_ENABLE_STDLIB_TRACING)
+  target_compile_definitions(swift_Concurrency
+    PRIVATE SWIFT_STDLIB_TRACING)
+  target_sources(swift_Concurrency
+    PRIVATE TracingSignpost.cpp)
+endif()
+
 if(APPLE)
   target_sources(swift_Concurrency PRIVATE
     CFExecutor.swift

Runtimes/Core/Core/CMakeLists.txt

@@ -80,6 +80,7 @@ add_library(swiftCore
   FlatMap.swift
   Flatten.swift
   FloatingPoint.swift
+  FloatingPointFromString.swift
   FloatingPointToString.swift
   Hashable.swift
   AnyHashable.swift # ORDER DEPENDENCY

Runtimes/Core/SwiftShims/swift/shims/CMakeLists.txt

@@ -22,7 +22,6 @@ install(FILES
   System.h
   Target.h
   ThreadLocalStorage.h
-  UnicodeData.h
   Visibility.h
   _SwiftConcurrency.h
   _SwiftDistributed.h

Runtimes/Core/cmake/caches/Vendors/Apple/apple-common.cmake

@@ -13,6 +13,7 @@ set(SwiftCore_ENABLE_RUNTIME_FUNCTION_COUNTERS ON CACHE BOOL "")
 set(SwiftCore_ENABLE_BACKDEPLOYMENT_SUPPORT ON CACHE BOOL "")
 set(SwiftCore_ENABLE_FILESYSTEM_SUPPORT ON CACHE BOOL "")
 set(SwiftCore_ENABLE_STRICT_AVAILABILITY ON CACHE BOOL "")
+set(SwiftCore_ENABLE_STDLIB_TRACING ON CACHE BOOL "")
 
 set(SwiftCore_OPTIMIZATION_REMARKS "bitstream" CACHE STRING "")
 

Runtimes/Core/runtime/CMakeLists.txt

@@ -72,6 +72,14 @@ if(SwiftCore_ENABLE_FILESYSTEM_SUPPORT AND (NOT SwiftCore_ARCH_SUBDIR OR NOT Swi
   message(SEND_ERROR "Filesystem support requires setting `SwiftCore_ARCH_SUBDIR` and `SwiftCore_PLATFORM_SUBDIR`")
 endif()
 
+if(SwiftCore_ENABLE_STDLIB_TRACING)
+  check_symbol_exists("os_signpost_interval_begin" "os/signpost.h" SwiftCore_HAS_OS_SIGNPOST)
+  check_symbol_exists("os_log" "os/log.h" SwiftCore_HAS_OS_LOG)
+  if(NOT SwiftCore_HAS_OS_LOG OR NOT SwiftCore_HAS_OS_SIGNPOST)
+    message(SEND_ERROR "Tracing requires 'os_signpost' and 'os_log' APIs")
+  endif()
+endif()
+
 # TODO: Probably worth considering putting half of these in a RuntimeConfig.h.in
 #       file rather than pushing them through macro flags.
 target_compile_definitions(swiftRuntime

Runtimes/Overlay/Android/Math/CMakeLists.txt

@@ -5,7 +5,8 @@ set_target_properties(swift_math PROPERTIES
   Swift_MODULE_NAME _math)
 target_link_libraries(swift_math PRIVATE
   SwiftAndroid
-  swiftCore)
+  swiftCore
+  swift_Builtin_float)
 
 install(TARGETS swift_math
   EXPORT SwiftOverlayTargets

Runtimes/Overlay/Android/clang/CMakeLists.txt

@@ -6,7 +6,7 @@ file(CONFIGURE
 ---
 version: 0
 case-sensitive: false
-use-external-names: false
+use-external-names: true
 roots:
   - name: "@CMAKE_ANDROID_NDK@/toolchains/llvm/prebuilt/windows-x86_64/sysroot/usr/include"
     type: directory