AST: Always-on ASSERTs for ProtocolConformanceRef

If any of the get*() methods are called on the wrong kind of
ProtocolConformanceRef, we immediately cast a pointer to an
incorrect type, which will most likely cause a crash.

Author: slavapestov

include/swift/AST/ProtocolConformanceRef.h

@@ -19,6 +19,7 @@
 #include "swift/AST/ProtocolConformanceRef.h"
 #include "swift/AST/Type.h"
 #include "swift/AST/TypeAlignments.h"
+#include "swift/Basic/Assertions.h"
 #include "swift/Basic/Debug.h"
 #include "llvm/ADT/Hashing.h"
 #include "llvm/ADT/PointerUnion.h"
@@ -101,13 +102,15 @@ class ProtocolConformanceRef {
     return !isInvalid() && Union.is<ProtocolConformance*>();
   }
   ProtocolConformance *getConcrete() const {
+    ASSERT(isConcrete());
     return Union.get<ProtocolConformance*>();
   }
 
   bool isPack() const {
     return !isInvalid() && Union.is<PackConformance*>();
   }
   PackConformance *getPack() const {
+    ASSERT(isPack());
     return Union.get<PackConformance*>();
   }
 
@@ -116,6 +119,7 @@ class ProtocolConformanceRef {
   }
 
   ProtocolDecl *getAbstract() const {
+    ASSERT(isAbstract());
     return Union.get<ProtocolDecl*>();
   }
 

lib/AST/ProtocolConformanceRef.cpp

@@ -49,8 +49,6 @@ bool ProtocolConformanceRef::isInvalid() const {
 }
 
 ProtocolDecl *ProtocolConformanceRef::getRequirement() const {
-  assert(!isInvalid());
-
   if (isConcrete()) {
     return getConcrete()->getProtocol();
   } else if (isPack()) {