[embedded] Relax getOrCreateFunction assert instead of changing serialization rules

Author: kubamracek

lib/SIL/IR/SILFunctionBuilder.cpp

@@ -32,7 +32,7 @@ SILFunction *SILFunctionBuilder::getOrCreateFunction(
   if (auto fn = mod.lookUpFunction(name)) {
     assert(fn->getLoweredFunctionType() == type);
     assert(stripExternalFromLinkage(fn->getLinkage()) ==
-           stripExternalFromLinkage(linkage));
+           stripExternalFromLinkage(linkage) || mod.getOptions().EmbeddedSwift);
     return fn;
   }
 

lib/SILOptimizer/IPO/CrossModuleOptimization.cpp

@@ -491,7 +491,7 @@ void CrossModuleOptimization::serializeFunction(SILFunction *function,
   if (function->isSerialized())
     return;
 
-  if (!everything && !canSerializeFlags.lookup(function))
+  if (!canSerializeFlags.lookup(function))
     return;
 
   function->setSerialized(IsSerialized);
@@ -588,14 +588,9 @@ void CrossModuleOptimization::keepMethodAlive(SILDeclRef method) {
 
 void CrossModuleOptimization::makeFunctionUsableFromInline(SILFunction *function) {
   assert(canUseFromInline(function));
-  if (!isAvailableExternally(function->getLinkage())) {
-    bool shouldPromoteToPublic = function->getLinkage() != SILLinkage::Public;
-    if (everything)
-      shouldPromoteToPublic = function->getLinkage() != SILLinkage::Public &&
-                              function->getLinkage() != SILLinkage::Shared;
-    if (shouldPromoteToPublic) {
-      function->setLinkage(SILLinkage::Public);
-    }
+  if (!isAvailableExternally(function->getLinkage()) &&
+      function->getLinkage() != SILLinkage::Public) {
+    function->setLinkage(SILLinkage::Public);
   }
 }