Sema: Fix null pointer dereference with invalid ParamDecl

Author: slavapestov

lib/Sema/TypeCheckDecl.cpp

@@ -2248,13 +2248,20 @@ ParamSpecifierRequest::evaluate(Evaluator &evaluator,
 
   auto typeRepr = param->getTypeRepr();
 
-  if (!typeRepr && !param->isImplicit()) {
-    // Untyped closure parameter.
-    return ParamSpecifier::Default;
-  }
+  if (!typeRepr) {
+    if (!param->isImplicit()) {
+      // Untyped closure parameter.
+      return ParamSpecifier::Default;
+    }
 
-  assert(typeRepr != nullptr && "Should call setSpecifier() on "
-         "synthesized parameter declarations");
+    if (param->isInvalid()) {
+      // Invalid parse.
+      return ParamSpecifier::Default;
+    }
+
+    ASSERT(false && "Should call setSpecifier() on "
+           "synthesized parameter declarations");
+  }
 
   // Look through top-level pack expansions.  These specifiers are
   // part of what's repeated.

…mpiler_crashers_2/d03a7ba9ca6274b0.swift …_crashers_2_fixed/d03a7ba9ca6274b0.swiftvalidation-test/compiler_crashers_2/d03a7ba9ca6274b0.swift renamed to validation-test/compiler_crashers_2_fixed/d03a7ba9ca6274b0.swift validation-test/compiler_crashers_2/d03a7ba9ca6274b0.swift renamed to validation-test/compiler_crashers_2_fixed/d03a7ba9ca6274b0.swift

@@ -1,3 +1,3 @@
 // {"signature":"swift::ParamSpecifierRequest::evaluate(swift::Evaluator&, swift::ParamDecl*) const"}
-// RUN: not --crash %target-swift-frontend -typecheck %s
+// RUN: not %target-swift-frontend -typecheck %s
 func a([0])