Fix old_runtime_crash_without_fixed_layout.swift to pass when optimizations are on

slavapestov · slavapestov · commit 2633c9d063db · 2019-02-22T21:10:18.000-05:00
@_optimize(none) does not prevent LLVM from optimizing the function, and the LLVM
optimizer was able to inline blackHole() and elide the metadata access altogether.
diff --git a/validation-test/Runtime/old_runtime_crash_without_fixed_layout.swift b/validation-test/Runtime/old_runtime_crash_without_fixed_layout.swift
@@ -29,7 +29,7 @@ public class ClassWithResilientField {
 @_optimize(none) func blackHole<T>(_: T) {}
 
 @_optimize(none) func forceMetadata() {
-  blackHole(ClassWithResilientField.self)
+  blackHole(ClassWithResilientField())
 }
 
 if #available(macOS 10.14.4, iOS 12.2, tvOS 12.2, watchOS 5.2, *) {

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public class ClassWithResilientField {`
`29`	`29`	`@_optimize(none) func blackHole<T>(_: T) {}`
`30`	`30`
`31`	`31`	`@_optimize(none) func forceMetadata() {`
`32`		`- blackHole(ClassWithResilientField.self)`
	`32`	`+ blackHole(ClassWithResilientField())`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`if #available(macOS 10.14.4, iOS 12.2, tvOS 12.2, watchOS 5.2, *) {`