[Diagnostics] Remove obsolete special case for _ = nil

xedin · xedin · commit f96d6d348679 · 2020-09-25T15:56:18.000-07:00
diff --git a/lib/Sema/CSDiagnostics.cpp b/lib/Sema/CSDiagnostics.cpp
@@ -6980,13 +6980,6 @@ bool MissingContextualTypeForNil::diagnoseAsError() {
       emitDiagnostic(diag::unresolved_nil_literal);
       return true;
     }
-    // `_ = nil`
-    if (auto *assignment = dyn_cast<AssignExpr>(parentExpr)) {
-      if (isa<DiscardAssignmentExpr>(assignment->getDest())) {
-        emitDiagnostic(diag::unresolved_nil_literal);
-        return true;
-      }
-    }
   }
 
   emitDiagnostic(diag::unresolved_nil_literal);

Original file line number	Diff line number	Diff line change
`@@ -6980,13 +6980,6 @@ bool MissingContextualTypeForNil::diagnoseAsError() {`
`6980`	`6980`	`emitDiagnostic(diag::unresolved_nil_literal);`
`6981`	`6981`	`return true;`
`6982`	`6982`	`}`
`6983`		- // `_ = nil`
`6984`		`- if (auto *assignment = dyn_cast<AssignExpr>(parentExpr)) {`
`6985`		`- if (isa<DiscardAssignmentExpr>(assignment->getDest())) {`
`6986`		`- emitDiagnostic(diag::unresolved_nil_literal);`
`6987`		`- return true;`
`6988`		`- }`
`6989`		`- }`
`6990`	`6983`	`}`
`6991`	`6984`
`6992`	`6985`	`emitDiagnostic(diag::unresolved_nil_literal);`