[Console] Optimize mostRecentlyEnteredValue() method

dmitrijivanenko · nicolas-grekas · commit c3da86291d89 · 2025-10-15T10:15:57.000+02:00
diff --git a/Helper/QuestionHelper.php b/Helper/QuestionHelper.php
@@ -379,12 +379,13 @@ private function mostRecentlyEnteredValue(string $entered): string
             return $entered;
         }
 
-        $choices = explode(',', $entered);
-        if ('' !== $lastChoice = trim($choices[\count($choices) - 1])) {
-            return $lastChoice;
+        if (false === $lastCommaPos = strrpos($entered, ',')) {
+            return $entered;
         }
 
-        return $entered;
+        $lastChoice = trim(substr($entered, $lastCommaPos + 1));
+
+        return '' !== $lastChoice ? $lastChoice : $entered;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -379,12 +379,13 @@ private function mostRecentlyEnteredValue(string $entered): string`
`379`	`379`	`return $entered;`
`380`	`380`	`}`
`381`	`381`
`382`		`- $choices = explode(',', $entered);`
`383`		`- if ('' !== $lastChoice = trim($choices[\count($choices) - 1])) {`
`384`		`- return $lastChoice;`
	`382`	`+ if (false === $lastCommaPos = strrpos($entered, ',')) {`
	`383`	`+ return $entered;`
`385`	`384`	`}`
`386`	`385`
`387`		`- return $entered;`
	`386`	`+ $lastChoice = trim(substr($entered, $lastCommaPos + 1));`
	`387`	`+`
	`388`	`+ return '' !== $lastChoice ? $lastChoice : $entered;`
`388`	`389`	`}`
`389`	`390`
`390`	`391`	`/**`