minor #1459 Simplify logout (javiereguiluz)

This PR was squashed before being merged into the main branch.

Discussion
----------

Simplify logout

I checked the list of Symfony 6.4 features, and this is the only one that I think it fits this application. So, let's use it.

Commits
-------

10277e6 Simplify logout

Author: javiereguiluz

config/packages/security.yaml

@@ -49,8 +49,6 @@ security:
                 #always_remember_me: true
 
             logout:
-                # The route name the user can go to in order to logout
-                path: security_logout
                 # The name of the route to redirect to after logging out
                 target: homepage
                 # Secure the logout against CSRF

src/Controller/SecurityController.php

@@ -59,16 +59,4 @@ public function login(
             'error' => $helper->getLastAuthenticationError(),
         ]);
     }
-
-    /**
-     * This is the route the user can use to logout.
-     *
-     * But, this will never be executed. Symfony will intercept this first
-     * and handle the logout automatically. See logout in config/packages/security.yaml
-     */
-    #[Route('/logout', name: 'security_logout')]
-    public function logout(): void
-    {
-        throw new \Exception('This should never be reached!');
-    }
 }

tests/Controller/UserControllerTest.php

@@ -104,7 +104,7 @@ public function testChangePassword(): void
 
         $this->assertResponseRedirects();
         $this->assertStringStartsWith(
-            '/en/logout',
+            '/logout',
             $client->getResponse()->headers->get('Location') ?? '',
             'Changing password logout the user.'
         );