Merge branch '3.0' into 3.1

* 3.0:
  fixed CS
  fixed CS
  fixed form tests
  [Console] Fix formatting of SymfonyStyle::comment()
  [Form] fix post max size translation type extension for >= 2.8
  removed dots at the end of @param and @return
  fixed typo

Author: fabpot

Compiler/AnalyzeServiceReferencesPass.php

@@ -120,7 +120,7 @@ private function processArguments(array $arguments)
     /**
      * Returns a service definition given the full name or an alias.
      *
-     * @param string $id A full id or alias for a service definition.
+     * @param string $id A full id or alias for a service definition
      *
      * @return Definition|null The definition related to the supplied id
      */

ContainerBuilder.php

@@ -458,7 +458,7 @@ public function get($id, $invalidBehavior = ContainerInterface::EXCEPTION_ON_INV
      * parameter, the value will still be 'bar' as defined in the ContainerBuilder
      * constructor.
      *
-     * @param ContainerBuilder $container The ContainerBuilder instance to merge.
+     * @param ContainerBuilder $container The ContainerBuilder instance to merge
      *
      * @throws BadMethodCallException When this ContainerBuilder is frozen
      */
@@ -944,7 +944,7 @@ public function resolveServices($value)
      *
      * @param string $name The tag name
      *
-     * @return array An array of tags with the tagged service as key, holding a list of attribute arrays.
+     * @return array An array of tags with the tagged service as key, holding a list of attribute arrays
      */
     public function findTaggedServiceIds($name)
     {
@@ -1000,7 +1000,7 @@ public function getExpressionLanguageProviders()
     /**
      * Returns the Service Conditionals.
      *
-     * @param mixed $value An array of conditionals to return.
+     * @param mixed $value An array of conditionals to return
      *
      * @return array An array of Service conditionals
      */

DefinitionDecorator.php

@@ -25,7 +25,7 @@ class DefinitionDecorator extends Definition
     private $changes = array();
 
     /**
-     * @param string $parent The id of Definition instance to decorate.
+     * @param string $parent The id of Definition instance to decorate
      */
     public function __construct($parent)
     {

Dumper/PhpDumper.php

@@ -571,16 +571,16 @@ private function addService($id, $definition)
         if ($definition->isSynthetic()) {
             $return[] = '@throws RuntimeException always since this service is expected to be injected dynamically';
         } elseif ($class = $definition->getClass()) {
-            $return[] = sprintf('@return %s A %s instance.', 0 === strpos($class, '%') ? 'object' : '\\'.ltrim($class, '\\'), ltrim($class, '\\'));
+            $return[] = sprintf('@return %s A %s instance', 0 === strpos($class, '%') ? 'object' : '\\'.ltrim($class, '\\'), ltrim($class, '\\'));
         } elseif ($definition->getFactory()) {
             $factory = $definition->getFactory();
             if (is_string($factory)) {
-                $return[] = sprintf('@return object An instance returned by %s().', $factory);
+                $return[] = sprintf('@return object An instance returned by %s()', $factory);
             } elseif (is_array($factory) && (is_string($factory[0]) || $factory[0] instanceof Definition || $factory[0] instanceof Reference)) {
                 if (is_string($factory[0]) || $factory[0] instanceof Reference) {
-                    $return[] = sprintf('@return object An instance returned by %s::%s().', (string) $factory[0], $factory[1]);
+                    $return[] = sprintf('@return object An instance returned by %s::%s()', (string) $factory[0], $factory[1]);
                 } elseif ($factory[0] instanceof Definition) {
-                    $return[] = sprintf('@return object An instance returned by %s::%s().', $factory[0]->getClass(), $factory[1]);
+                    $return[] = sprintf('@return object An instance returned by %s::%s()', $factory[0]->getClass(), $factory[1]);
                 }
             }
         }

Tests/Fixtures/php/services10.php

@@ -47,7 +47,7 @@ public function compile()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \stdClass A stdClass instance.
+     * @return \stdClass A stdClass instance
      */
     protected function getTestService()
     {

Tests/Fixtures/php/services12.php

@@ -51,7 +51,7 @@ public function compile()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \stdClass A stdClass instance.
+     * @return \stdClass A stdClass instance
      */
     protected function getTestService()
     {

Tests/Fixtures/php/services13.php

@@ -45,7 +45,7 @@ public function compile()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \stdClass A stdClass instance.
+     * @return \stdClass A stdClass instance
      */
     protected function getBarService()
     {

Tests/Fixtures/php/services19.php

@@ -36,7 +36,7 @@ public function __construct()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \Bar\FooClass A Bar\FooClass instance.
+     * @return \Bar\FooClass A Bar\FooClass instance
      */
     protected function getServiceFromAnonymousFactoryService()
     {
@@ -49,7 +49,7 @@ protected function getServiceFromAnonymousFactoryService()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \Bar\FooClass A Bar\FooClass instance.
+     * @return \Bar\FooClass A Bar\FooClass instance
      */
     protected function getServiceWithMethodCallAndFactoryService()
     {

Tests/Fixtures/php/services24.php

@@ -34,7 +34,7 @@ public function __construct()
      *
      * This service is autowired.
      *
-     * @return \Foo A Foo instance.
+     * @return \Foo A Foo instance
      */
     protected function getFooService()
     {

Tests/Fixtures/php/services9.php

@@ -61,7 +61,7 @@ public function __construct()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \Bar\FooClass A Bar\FooClass instance.
+     * @return \Bar\FooClass A Bar\FooClass instance
      */
     protected function getBarService()
     {
@@ -80,7 +80,7 @@ protected function getBarService()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \Baz A Baz instance.
+     * @return \Baz A Baz instance
      */
     protected function getBazService()
     {
@@ -97,7 +97,7 @@ protected function getBazService()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \stdClass A stdClass instance.
+     * @return \stdClass A stdClass instance
      */
     protected function getConfiguredServiceService()
     {
@@ -114,7 +114,7 @@ protected function getConfiguredServiceService()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \stdClass A stdClass instance.
+     * @return \stdClass A stdClass instance
      */
     protected function getConfiguredServiceSimpleService()
     {
@@ -131,7 +131,7 @@ protected function getConfiguredServiceSimpleService()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \stdClass A stdClass instance.
+     * @return \stdClass A stdClass instance
      */
     protected function getDecoratedService()
     {
@@ -144,7 +144,7 @@ protected function getDecoratedService()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \stdClass A stdClass instance.
+     * @return \stdClass A stdClass instance
      */
     protected function getDecoratorServiceService()
     {
@@ -157,7 +157,7 @@ protected function getDecoratorServiceService()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \stdClass A stdClass instance.
+     * @return \stdClass A stdClass instance
      */
     protected function getDecoratorServiceWithNameService()
     {
@@ -170,7 +170,7 @@ protected function getDecoratorServiceWithNameService()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \stdClass A stdClass instance.
+     * @return \stdClass A stdClass instance
      *
      * @deprecated The "deprecated_service" service is deprecated. You should stop using it, as it will soon be removed.
      */
@@ -187,7 +187,7 @@ protected function getDeprecatedServiceService()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \Bar A Bar instance.
+     * @return \Bar A Bar instance
      */
     protected function getFactoryServiceService()
     {
@@ -200,7 +200,7 @@ protected function getFactoryServiceService()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \Bar A Bar instance.
+     * @return \Bar A Bar instance
      */
     protected function getFactoryServiceSimpleService()
     {
@@ -213,7 +213,7 @@ protected function getFactoryServiceSimpleService()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \Bar\FooClass A Bar\FooClass instance.
+     * @return \Bar\FooClass A Bar\FooClass instance
      */
     protected function getFooService()
     {
@@ -237,7 +237,7 @@ protected function getFooService()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return object A %baz_class% instance.
+     * @return object A %baz_class% instance
      */
     protected function getFoo_BazService()
     {
@@ -251,7 +251,7 @@ protected function getFoo_BazService()
     /**
      * Gets the 'foo_bar' service.
      *
-     * @return object A %foo_class% instance.
+     * @return object A %foo_class% instance
      */
     protected function getFooBarService()
     {
@@ -266,7 +266,7 @@ protected function getFooBarService()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \Foo A Foo instance.
+     * @return \Foo A Foo instance
      */
     protected function getFooWithInlineService()
     {
@@ -283,7 +283,7 @@ protected function getFooWithInlineService()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \Bar\FooClass A Bar\FooClass instance.
+     * @return \Bar\FooClass A Bar\FooClass instance
      */
     protected function getMethodCall1Service()
     {
@@ -310,7 +310,7 @@ protected function getMethodCall1Service()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \FooBarBaz A FooBarBaz instance.
+     * @return \FooBarBaz A FooBarBaz instance
      */
     protected function getNewFactoryServiceService()
     {
@@ -340,7 +340,7 @@ protected function getRequestService()
      * This service is shared.
      * This method always returns the same instance of the service.
      *
-     * @return \Bar\FooClass A Bar\FooClass instance.
+     * @return \Bar\FooClass A Bar\FooClass instance
      */
     protected function getServiceFromStaticMethodService()
     {
@@ -357,7 +357,7 @@ protected function getServiceFromStaticMethodService()
      * If you want to be able to request this service from the container directly,
      * make it public, otherwise you might end up with broken code.
      *
-     * @return \ConfClass A ConfClass instance.
+     * @return \ConfClass A ConfClass instance
      */
     protected function getConfiguratorServiceService()
     {
@@ -378,7 +378,7 @@ protected function getConfiguratorServiceService()
      * If you want to be able to request this service from the container directly,
      * make it public, otherwise you might end up with broken code.
      *
-     * @return \ConfClass A ConfClass instance.
+     * @return \ConfClass A ConfClass instance
      */
     protected function getConfiguratorServiceSimpleService()
     {
@@ -395,7 +395,7 @@ protected function getConfiguratorServiceSimpleService()
      * If you want to be able to request this service from the container directly,
      * make it public, otherwise you might end up with broken code.
      *
-     * @return \SimpleFactoryClass A SimpleFactoryClass instance.
+     * @return \SimpleFactoryClass A SimpleFactoryClass instance
      */
     protected function getFactorySimpleService()
     {
@@ -412,7 +412,7 @@ protected function getFactorySimpleService()
      * If you want to be able to request this service from the container directly,
      * make it public, otherwise you might end up with broken code.
      *
-     * @return \Bar A Bar instance.
+     * @return \Bar A Bar instance
      */
     protected function getInlinedService()
     {
@@ -434,7 +434,7 @@ protected function getInlinedService()
      * If you want to be able to request this service from the container directly,
      * make it public, otherwise you might end up with broken code.
      *
-     * @return \FactoryClass A FactoryClass instance.
+     * @return \FactoryClass A FactoryClass instance
      */
     protected function getNewFactoryService()
     {