Merge branch '5.4' into 6.2

* 5.4:
  Migrate to `static` data providers using `rector/rector`

Author: nicolas-grekas

Tests/AbstractLayoutTestCase.php

@@ -2794,7 +2794,7 @@ public function testSubmitFormNoValidate(bool $validate)
         $this->assertMatchesXpath($html, $xpath);
     }
 
-    public function submitFormNoValidateProvider()
+    public static function submitFormNoValidateProvider()
     {
         return [
             [false],

Tests/AbstractRequestHandlerTestCase.php

@@ -75,7 +75,7 @@ public static function methodExceptGetProvider()
         ];
     }
 
-    public function methodProvider()
+    public static function methodProvider()
     {
         return array_merge([
             ['GET'],
@@ -348,7 +348,7 @@ public function testAddFormErrorIfPostMaxSizeExceeded(?int $contentLength, strin
         }
     }
 
-    public function getPostMaxSizeFixtures()
+    public static function getPostMaxSizeFixtures()
     {
         return [
             [1024 ** 3 + 1, '1G', true, ['{{ max }}' => '1G']],
@@ -381,7 +381,7 @@ public function testFailedFileUploadIsTurnedIntoFormError($errorCode, $expectedE
         $this->assertSame($expectedErrorCode, $this->requestHandler->getUploadFileError($this->getFailedUploadedFile($errorCode)));
     }
 
-    public function uploadFileErrorCodes()
+    public static function uploadFileErrorCodes()
     {
         return [
             'no error' => [\UPLOAD_ERR_OK, null],

Tests/ButtonBuilderTest.php

@@ -20,7 +20,7 @@
  */
 class ButtonBuilderTest extends TestCase
 {
-    public function getValidNames()
+    public static function getValidNames()
     {
         return [
             ['reset'],
@@ -47,7 +47,7 @@ public function testNameContainingIllegalCharacters()
         $this->assertInstanceOf(ButtonBuilder::class, new ButtonBuilder('button[]'));
     }
 
-    public function getInvalidNames()
+    public static function getInvalidNames()
     {
         return [
             [''],

Tests/ButtonTest.php

@@ -57,7 +57,7 @@ public function testDisabledIfParentIsDisabled($parentDisabled, $buttonDisabled,
         $this->assertSame($result, $button->isDisabled());
     }
 
-    public function getDisabledStates()
+    public static function getDisabledStates()
     {
         return [
             // parent, button, result

Tests/ChoiceList/Factory/CachingFactoryDecoratorTest.php

@@ -555,7 +555,7 @@ public function testCreateViewDifferentAttributesClosure()
         $this->assertEquals(new ChoiceListView(), $view2);
     }
 
-    public function provideSameChoices()
+    public static function provideSameChoices()
     {
         $object = (object) ['foo' => 'bar'];
 
@@ -568,7 +568,7 @@ public function provideSameChoices()
         ];
     }
 
-    public function provideDistinguishedChoices()
+    public static function provideDistinguishedChoices()
     {
         return [
             [0, false],

Tests/Command/DebugCommandTest.php

@@ -197,7 +197,7 @@ public function testComplete(array $input, array $expectedSuggestions)
         $this->assertSame($expectedSuggestions, $tester->complete($input));
     }
 
-    public function provideCompletionSuggestions(): iterable
+    public static function provideCompletionSuggestions(): iterable
     {
         yield 'option --format' => [
             ['--format', ''],

Tests/CompoundFormTest.php

@@ -583,7 +583,7 @@ public function testSubmitMapsSubmittedChildrenOntoEmptyData()
         $this->assertSame('Bernhard', $object['name']);
     }
 
-    public function requestMethodProvider()
+    public static function requestMethodProvider()
     {
         return [
             ['POST'],

Tests/Console/Descriptor/AbstractDescriptorTestCase.php

@@ -80,7 +80,7 @@ public function testDescribeOption(OptionsResolver $optionsResolver, array $opti
         }
     }
 
-    public function getDescribeDefaultsTestData()
+    public static function getDescribeDefaultsTestData()
     {
         $options['core_types'] = ['Symfony\Component\Form\Extension\Core\Type\FormType'];
         $options['service_types'] = ['Symfony\Bridge\Doctrine\Form\Type\EntityType'];
@@ -96,7 +96,7 @@ public function getDescribeDefaultsTestData()
         yield [null, $options, 'types_with_deprecated_options'];
     }
 
-    public function getDescribeResolvedFormTypeTestData()
+    public static function getDescribeResolvedFormTypeTestData()
     {
         $typeExtensions = [new FormTypeCsrfExtension(new CsrfTokenManager())];
         $parent = new ResolvedFormType(new FormType(), $typeExtensions);
@@ -106,7 +106,7 @@ public function getDescribeResolvedFormTypeTestData()
         yield [new ResolvedFormType(new FooType(), [], $parent), ['decorated' => false, 'show_deprecated' => true], 'deprecated_options_of_type'];
     }
 
-    public function getDescribeOptionTestData()
+    public static function getDescribeOptionTestData()
     {
         $parent = new ResolvedFormType(new FormType());
         $options['decorated'] = false;

Tests/DependencyInjection/FormPassTest.php

@@ -118,7 +118,7 @@ public function testAddTaggedTypeExtensions(array $extensions, array $expectedRe
         $this->assertEquals($expectedRegisteredExtensions, $extDefinition->getArgument(1));
     }
 
-    public function addTaggedTypeExtensionsDataProvider()
+    public static function addTaggedTypeExtensionsDataProvider()
     {
         return [
             [
@@ -275,7 +275,7 @@ public function testPrivateTaggedServices($id, $class, $tagName, callable $asser
         $assertion($container);
     }
 
-    public function privateTaggedServicesProvider()
+    public static function privateTaggedServicesProvider()
     {
         return [
             [

Tests/Extension/Core/DataMapper/DataMapperTest.php

@@ -345,7 +345,7 @@ public function testMapFormsToDataDoesNotChangeEqualDateTimeInstance($date)
         self::assertSame($publishedAtValue, $article['publishedAt']);
     }
 
-    public function provideDate(): array
+    public static function provideDate(): array
     {
         return [
             [new \DateTime()],