bug #21104 [FrameworkBundle] fix IPv6 address handling in server commands (xabbuh)

nicolas-grekas · nicolas-grekas · commit 62bbde789bf2 · 2017-01-12T14:01:00.000+01:00
This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] fix IPv6 address handling in server commands | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#21039 (comment) | License | MIT | Doc PR | This fixes symfony/symfony#21039 (comment) as reported by @sstok for the existing commands by backporting @fabpot's patch from #21039. Commits ------- 2bb4713 fix IPv6 address handling in server commands
diff --git a/Command/ServerCommand.php b/Command/ServerCommand.php
@@ -54,7 +54,9 @@ protected function isOtherServerProcessRunning($address)
             return true;
         }
 
-        list($hostname, $port) = explode(':', $address);
+        $pos = strrpos($address, ':');
+        $hostname = substr($address, 0, $pos);
+        $port = substr($address, $pos + 1);
 
         $fp = @fsockopen($hostname, $port, $errno, $errstr, 5);
 

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,9 @@ protected function isOtherServerProcessRunning($address)`
`54`	`54`	`return true;`
`55`	`55`	`}`
`56`	`56`
`57`		`- list($hostname, $port) = explode(':', $address);`
	`57`	`+ $pos = strrpos($address, ':');`
	`58`	`+ $hostname = substr($address, 0, $pos);`
	`59`	`+ $port = substr($address, $pos + 1);`
`58`	`60`
`59`	`61`	`$fp = @fsockopen($hostname, $port, $errno, $errstr, 5);`
`60`	`62`