bug #62551 [FrameworkBundle] register attribute loader arguments in a forward-compatible way (xabbuh)

This PR was merged into the 6.4 branch.

Discussion
----------

[FrameworkBundle] register attribute loader arguments in a forward-compatible way

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #62549
| License       | MIT

Commits
-------

d0edddae7b4 register attribute loader arguments in a forward-compatible way

Author: derrabus

DependencyInjection/FrameworkExtension.php

@@ -163,6 +163,7 @@
 use Symfony\Component\Serializer\Mapping\Loader\AttributeLoader;
 use Symfony\Component\Serializer\Mapping\Loader\XmlFileLoader;
 use Symfony\Component\Serializer\Mapping\Loader\YamlFileLoader;
+use Symfony\Component\Serializer\Normalizer\CacheableSupportsMethodInterface;
 use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
 use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
 use Symfony\Component\Serializer\Serializer;
@@ -1954,7 +1955,7 @@ private function registerSerializerConfiguration(array $config, ContainerBuilder
         if (isset($config['enable_attributes']) && $config['enable_attributes']) {
             $annotationLoader = new Definition(
                 AttributeLoader::class,
-                [new Reference('annotation_reader', ContainerInterface::NULL_ON_INVALID_REFERENCE)]
+                interface_exists(CacheableSupportsMethodInterface::class) ? [new Reference('annotation_reader', ContainerInterface::NULL_ON_INVALID_REFERENCE)] : [],
             );
 
             $serializerLoaders[] = $annotationLoader;

Tests/DependencyInjection/Fixtures/php/serializer_attributes_enabled_annotations_enabled_globally.php

@@ -0,0 +1,8 @@
+<?php
+
+$container->loadFromExtension('framework', [
+    'annotations' => true,
+    'serializer' => [
+        'enable_attributes' => true,
+    ],
+]);

Tests/DependencyInjection/Fixtures/xml/serializer_attributes_enabled_annotations_enabled_globally.xml

@@ -0,0 +1,10 @@
+<?xml version="1.0" ?>
+<container xmlns="http://symfony.com/schema/dic/services"
+           xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+           xmlns:framework="http://symfony.com/schema/dic/symfony">
+
+    <framework:config>
+        <framework:annotations enabled="true" />
+        <framework:serializer enable-attributes="true" />
+    </framework:config>
+</container>

Tests/DependencyInjection/Fixtures/yml/serializer_attributes_enabled_annotations_enabled_globally.yml

@@ -0,0 +1,4 @@
+framework:
+    annotations: true
+    serializer:
+        enable_attributes: true

Tests/DependencyInjection/FrameworkExtensionTestCase.php

@@ -67,6 +67,7 @@
 use Symfony\Component\Notifier\TexterInterface;
 use Symfony\Component\PropertyAccess\PropertyAccessor;
 use Symfony\Component\Security\Core\AuthenticationEvents;
+use Symfony\Component\Serializer\Mapping\Loader\AnnotationLoader;
 use Symfony\Component\Serializer\Mapping\Loader\AttributeLoader;
 use Symfony\Component\Serializer\Mapping\Loader\XmlFileLoader;
 use Symfony\Component\Serializer\Mapping\Loader\YamlFileLoader;
@@ -1711,6 +1712,23 @@ public function testSerializerCacheNotActivatedWithAnnotations()
         $this->assertFalse($container->hasDefinition('serializer.mapping.cache_class_metadata_factory'));
     }
 
+    /**
+     * @group legacy
+     */
+    public function testSerializerAttributesEnabledAnnotationsEnabledGlobally()
+    {
+        $container = $this->createContainerFromFile('serializer_attributes_enabled_annotations_enabled_globally');
+        $cacheWarmer = $container->getDefinition('serializer.mapping.cache_warmer');
+        $loaders = $cacheWarmer->getArgument(0);
+        $attributeLoader = $loaders[0];
+
+        if (class_exists(AnnotationLoader::class)) {
+            $this->assertEquals([new Reference('annotation_reader', ContainerInterface::NULL_ON_INVALID_REFERENCE)], $attributeLoader->getArguments());
+        } else {
+            $this->assertSame([], $attributeLoader->getArguments());
+        }
+    }
+
     public function testSerializerMapping()
     {
         $container = $this->createContainerFromFile('serializer_mapping_without_annotations', ['kernel.bundles_metadata' => ['TestBundle' => ['namespace' => 'Symfony\\Bundle\\FrameworkBundle\\Tests', 'path' => __DIR__.'/Fixtures/TestBundle']]]);