Merge branch '5.4' into 6.0

* 5.4:
  [Notifier] fix firebase error handling so the transports doesn't try setting the success message, that doesn't exists.
  Remove wrong dep
  [Translation] Fix message key handling for the Localise provider
  [Serializer] Deprecate support for returning empty, iterable, countable, raw object when normalizing
  Fix ProgressBar to correctly clear multi-line formats
  [Mailer] Consume a PSR-14 event dispatcher
  Ignoring X-Transport header while signing email with DKIM
  Remove polyfills from ExpressionLanguage
  Update validators.tr.xlf
  [Form] fix typo in Danish translation
  [HttpKernel] Fix timestamp_rfc3339 in LoggerDataCollector
  Remove broken test case
  [PropertyInfo] Support for the never return type
  Show nice CLI output in Psalm action
  add more explicit error

Signed-off-by: Alexander M. Turek <me@derrabus.de>

Author: derrabus

Notifier.php

@@ -15,6 +15,7 @@
 use Symfony\Component\Notifier\Channel\ChannelInterface;
 use Symfony\Component\Notifier\Channel\ChannelPolicy;
 use Symfony\Component\Notifier\Channel\ChannelPolicyInterface;
+use Symfony\Component\Notifier\Channel\SmsChannel;
 use Symfony\Component\Notifier\Exception\LogicException;
 use Symfony\Component\Notifier\Notification\Notification;
 use Symfony\Component\Notifier\Recipient\NoRecipient;
@@ -89,6 +90,10 @@ private function getChannels(Notification $notification, RecipientInterface $rec
                 throw new LogicException(sprintf('The "%s" channel does not exist.', $channelName));
             }
 
+            if ($channel instanceof SmsChannel && $recipient instanceof NoRecipient) {
+                throw new LogicException(sprintf('The "%s" channel needs a Recipient.', $channelName));
+            }
+
             if (!$channel->supports($notification, $recipient)) {
                 throw new LogicException(sprintf('The "%s" channel is not supported.', $channelName));
             }

Tests/NotifierTest.php

@@ -0,0 +1,25 @@
+<?php
+
+namespace Symfony\Component\Notifier\Tests;
+
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\Notifier\Channel\SmsChannel;
+use Symfony\Component\Notifier\Exception\LogicException;
+use Symfony\Component\Notifier\Notification\Notification;
+use Symfony\Component\Notifier\Notifier;
+use Symfony\Component\Notifier\Transport\NullTransport;
+
+/**
+ * @author Smaïne Milianni <smaine.milianni@gmail.com>
+ */
+final class NotifierTest extends TestCase
+{
+    public function testItThrowAnExplicitErrorIfAnSmsChannelDoesNotHaveRecipient()
+    {
+        $this->expectException(LogicException::class);
+        $this->expectExceptionMessage('The "sms" channel needs a Recipient.');
+
+        $notifier = new Notifier(['sms' => new SmsChannel(new NullTransport())]);
+        $notifier->send(new Notification('Hello World!', ['sms/twilio']));
+    }
+}