feature #1203 [Translator][LiveComponent] Fix cache warmers compatibility with Symfony 6.4 (norkunas)

weaverryan · weaverryan · commit 4fb9e453818c · 2023-10-20T14:47:15.000-04:00
This PR was merged into the 2.x branch. Discussion ---------- [Translator][LiveComponent] Fix cache warmers compatibility with Symfony 6.4 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Tickets | N/A | License | MIT Commits ------- 4a574dd [Translator][LiveComponent] Fix cache warmers compatibility with Symfony 6.4
diff --git a/src/LiveComponent/src/Twig/TemplateCacheWarmer.php b/src/LiveComponent/src/Twig/TemplateCacheWarmer.php
@@ -26,7 +26,7 @@ public function __construct(private \IteratorAggregate $templateIterator, privat
     {
     }
 
-    public function warmUp(string $cacheDir): array
+    public function warmUp(string $cacheDir, string $buildDir = null): array
     {
         $map = [];
         foreach ($this->templateIterator as $item) {
diff --git a/src/Translator/src/CacheWarmer/TranslationsCacheWarmer.php b/src/Translator/src/CacheWarmer/TranslationsCacheWarmer.php
@@ -33,7 +33,7 @@ public function isOptional(): bool
         return true;
     }
 
-    public function warmUp(string $cacheDir): array
+    public function warmUp(string $cacheDir, string $buildDir = null): array
     {
         $this->translationsDumper->dump(
             ...$this->translatorBag->getCatalogues()

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ public function __construct(private \IteratorAggregate $templateIterator, privat`
`26`	`26`	`{`
`27`	`27`	`}`
`28`	`28`
`29`		`- public function warmUp(string $cacheDir): array`
	`29`	`+ public function warmUp(string $cacheDir, string $buildDir = null): array`
`30`	`30`	`{`
`31`	`31`	`$map = [];`
`32`	`32`	`foreach ($this->templateIterator as $item) {`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ public function isOptional(): bool`
`33`	`33`	`return true;`
`34`	`34`	`}`
`35`	`35`
`36`		`- public function warmUp(string $cacheDir): array`
	`36`	`+ public function warmUp(string $cacheDir, string $buildDir = null): array`
`37`	`37`	`{`
`38`	`38`	`$this->translationsDumper->dump(`
`39`	`39`	`...$this->translatorBag->getCatalogues()`