bug #1112 [Live] array return on cache warmer (weaverryan)

weaverryan · weaverryan · commit 69e35316147c · 2023-09-13T10:16:57.000-04:00
This PR was merged into the 2.x branch. Discussion ---------- [Live] array return on cache warmer | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Tickets | None | License | MIT `warmUp` has a documented array return type, which will become a true return type in Symfony 7. Commits ------- 8cafe5a [Live] array return on cache warmer
diff --git a/src/LiveComponent/src/Twig/TemplateCacheWarmer.php b/src/LiveComponent/src/Twig/TemplateCacheWarmer.php
@@ -26,14 +26,16 @@ public function __construct(private \IteratorAggregate $templateIterator, privat
     {
     }
 
-    public function warmUp(string $cacheDir): void
+    public function warmUp(string $cacheDir): array
     {
         $map = [];
         foreach ($this->templateIterator as $item) {
             $map[bin2hex(random_bytes(16))] = $item;
         }
 
         (new PhpArrayAdapter($cacheDir.'/'.$this->cacheFilename, new NullAdapter()))->warmUp(['map' => $map]);
+
+        return [];
     }
 
     public function isOptional(): bool

Original file line number	Diff line number	Diff line change
`@@ -26,14 +26,16 @@ public function __construct(private \IteratorAggregate $templateIterator, privat`
`26`	`26`	`{`
`27`	`27`	`}`
`28`	`28`
`29`		`- public function warmUp(string $cacheDir): void`
	`29`	`+ public function warmUp(string $cacheDir): array`
`30`	`30`	`{`
`31`	`31`	`$map = [];`
`32`	`32`	`foreach ($this->templateIterator as $item) {`
`33`	`33`	`$map[bin2hex(random_bytes(16))] = $item;`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`(new PhpArrayAdapter($cacheDir.'/'.$this->cacheFilename, new NullAdapter()))->warmUp(['map' => $map]);`
	`37`	`+`
	`38`	`+ return [];`
`37`	`39`	`}`
`38`	`40`
`39`	`41`	`public function isOptional(): bool`