bug #1288 [TwigComponent] Merge data-action in ComponentAttributes (weaverryan)

This PR was merged into the 2.x branch.

Discussion
----------

[TwigComponent] Merge data-action in ComponentAttributes

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| Issues        | None that I know of
| License       | MIT

If you pass `data-action` into a component & the root `attributes` has a `data-action` already thanks to `attributes.defaults`, they should be merged together. Same behavior as `data-controller`. I found this while adding a `data-action` to a component and suddenly losing my existing `data-action` from inside.

Cheers!

Commits
-------

0cafa36 [TwigComponent] Merge data-action when using ComponentAttributes

Author: weaverryan

src/TwigComponent/src/ComponentAttributes.php

@@ -80,7 +80,7 @@ public function defaults(iterable $attributes): self
         }
 
         foreach ($this->attributes as $key => $value) {
-            if (\in_array($key, ['class', 'data-controller'], true) && isset($attributes[$key])) {
+            if (\in_array($key, ['class', 'data-controller', 'data-action'], true) && isset($attributes[$key])) {
                 $attributes[$key] = "{$attributes[$key]} {$value}";
 
                 continue;

src/TwigComponent/tests/Unit/ComponentAttributesTest.php

@@ -146,6 +146,28 @@ public function testCanAddStimulusControllerViaStimulusAttributes(): void
         ], $attributes->all());
     }
 
+    public function testCanAddStimulusActionViaStimulusAttributes(): void
+    {
+        // if PHP less than 8.1, skip
+        if (version_compare(\PHP_VERSION, '8.1.0', '<')) {
+            $this->markTestSkipped('PHP 8.1+ required');
+        }
+
+        $attributes = new ComponentAttributes([
+            'class' => 'foo',
+            'data-action' => 'live#foo',
+        ]);
+
+        $stimulusAttributes = new StimulusAttributes(new Environment(new ArrayLoader()));
+        $stimulusAttributes->addAction('foo', 'barMethod');
+        $attributes = $attributes->defaults([...$stimulusAttributes]);
+
+        $this->assertEquals([
+            'class' => 'foo',
+            'data-action' => 'foo#barMethod live#foo',
+        ], $attributes->all());
+    }
+
     public function testBooleanBehaviour(): void
     {
         $attributes = new ComponentAttributes(['disabled' => true]);