Skip to content

Commit c4a361b

Browse files
committed
iterate
1 parent 222e98c commit c4a361b

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/.utils.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,9 @@ export -f _run_task
3232
# Install specific versions of PropertyInfo and TypeInfo based on PHP and Symfony versions
3333
# To remove in Symfony UX 4.0
3434
live_component_post_install() {
35-
local php_version="$1"
36-
local symfony_version="$2"
35+
local php_version=$1
36+
local symfony_version=$2
3737

38-
# Lowest PHP version
3938
if [ "$php_version" = "8.1" ]; then
4039
# no-op, let Composer install the best PropertyInfo version (defined in composer.json), but do not require TypeInfo
4140
return 0
@@ -53,15 +52,16 @@ live_component_post_install() {
5352
return $?
5453
fi
5554

56-
if [ "$php_version" = "8.4" ]; then
55+
if [ "$php_version" = "8.4" ] && [ -z "$symfony_version" ]; then
5756
# Install PropertyInfo 7.3 (deprecate PropertyTypeExtractorInterface::getTypes) and TypeInfo 7.3 (new features and deprecations)
5857
composer require symfony/property-info:7.3.* symfony/type-info:7.3.*
5958
return $?
6059
fi
6160

61+
# Highest PHP version without Symfony version constraint
6262
if [ "$php_version" = "8.5" ]; then
63-
# Install PropertyInfo 7.3 (deprecate PropertyTypeExtractorInterface::getTypes) and TypeInfo 7.3 (new features and deprecations)
64-
composer require symfony/property-info:7.3.* symfony/type-info:7.3.*
63+
# Install the best TypeInfo version available
64+
composer require symfony/type-info
6565
return $?
6666
fi
6767

0 commit comments

Comments
 (0)