Skip to content

Commit c66f8c5

Browse files
committed
iterate
1 parent 3bbd031 commit c66f8c5

File tree

2 files changed

+18
-19
lines changed

2 files changed

+18
-19
lines changed

.github/workflows/.utils.sh

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -33,24 +33,23 @@ export -f _run_task
3333
# To remove in Symfony UX 4.0
3434
live_component_post_install() {
3535
local php_version=$1
36-
local symfony_version=$2
3736

38-
if [ "$php_version" = "8.1" ]; then
39-
# no-op, let Composer install the best PropertyInfo version (defined in composer.json), but do not require TypeInfo
40-
return 0
41-
fi
42-
43-
if [ "$php_version" = "8.2" ]; then
44-
# PropertyInfo 7.1 (experimental PropertyTypeExtractorInterface::getType) and TypeInfo 7.2 (lowest non-experimental)
45-
composer require symfony/property-info:7.1.* symfony/type-info:7.2.*
46-
return $?
47-
fi
48-
49-
if [ "$php_version" = "8.3" ]; then
50-
# Install PropertyInfo 7.3 (deprecate PropertyTypeExtractorInterface::getTypes) and TypeInfo 7.3 (new features and deprecations)
51-
composer require symfony/property-info:7.3.* symfony/type-info:7.3.*
52-
return $?
53-
fi
37+
case "$php_version" in
38+
8.1)
39+
# no-op, let Composer install the best PropertyInfo version (defined in composer.json), but do not require TypeInfo
40+
return 0
41+
;;
42+
8.2)
43+
# PropertyInfo 7.1 (experimental PropertyTypeExtractorInterface::getType) and TypeInfo 7.2 (lowest non-experimental)
44+
composer require symfony/property-info:7.1.* symfony/type-info:7.2.*
45+
return $?
46+
;;
47+
8.3)
48+
# Install PropertyInfo 7.3 (deprecate PropertyTypeExtractorInterface::getTypes) and TypeInfo 7.3 (new features and deprecations)
49+
composer require symfony/property-info:7.3.* symfony/type-info:7.3.*
50+
return $?
51+
;;
52+
esac
5453

5554
# Install the best TypeInfo version available
5655
composer require symfony/type-info

.github/workflows/unit-tests.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ jobs:
123123
'(cd src/{} \
124124
&& $COMPOSER_MIN_STAB \
125125
&& $COMPOSER_UP \
126-
&& if [ {} = LiveComponent ]; then live_component_post_install \"${{ matrix.php-version }}\" \"${{ matrix.symfony-version }}\"; fi \
126+
&& if [ {} = LiveComponent ]; then live_component_post_install \"${{ matrix.php-version }}\"; fi \
127127
&& $PHPUNIT)'"
128128
129129
- name: Run packages tests (Windows)
@@ -138,7 +138,7 @@ jobs:
138138
'(cd src/$PACKAGE \
139139
&& $COMPOSER_MIN_STAB \
140140
&& $COMPOSER_UP \
141-
&& if [ "$PACKAGE" = "LiveComponent" ]; then live_component_post_install \"${{ matrix.php-version }}\" \"${{ matrix.symfony-version }}\"; fi \
141+
&& if [ "$PACKAGE" = "LiveComponent" ]; then live_component_post_install \"${{ matrix.php-version }}\"; fi \
142142
&& $PHPUNIT)'; then
143143
FAILED_PACKAGES="$FAILED_PACKAGES $PACKAGE"
144144
fi

0 commit comments

Comments
 (0)