You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
feature #93 Moving Turbo to be a peer dependency (weaverryan)
This PR was squashed before being merged into the main branch.
Discussion
----------
Moving Turbo to be a peer dependency
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| Tickets | None
| License | MIT
Like with Stimulus itself, I believe this should be a peer dependency. The only downside is that users need to install it directly, which I don't see as a huge downside.
This should guarantee that the the same "turbo" module is used from both the symfony/ux-turbo package and the end-users code (as well as from any other libraries that could potentially list turbo as a peer dependency). It should also fix this annoying little line I get in PhpStorm ;)
<img width="867" alt="Screen Shot 2021-05-06 at 11 31 18 AM" src="https://user-images.githubusercontent.com/121003/117325305-954de100-ae5e-11eb-8959-4ca150f6ed49.png">
Cheers!
Commits
-------
b3c2d3d removing all package.json dependencies in favor of peer dependencies
d62a25b Moving Turbo to be a peer dependency
0 commit comments