bug #1117 [TwigComponent] Remove undefined var $name in ComponentExtension (smnandre)

weaverryan · weaverryan · commit fe076a9c72ad · 2023-09-18T14:08:16.000-04:00
This PR was merged into the 2.x branch. Discussion ---------- [TwigComponent] Remove undefined var $name in ComponentExtension | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Tickets | Fix #1115 | License | MIT Implement the solution suggested by `@kbond` here: #1115 (comment) Commits ------- 912658d [TwigComponent] Remove undefined var $name in ComponentExtension
diff --git a/src/TwigComponent/src/Twig/ComponentExtension.php b/src/TwigComponent/src/Twig/ComponentExtension.php
@@ -82,11 +82,7 @@ public function embeddedContext(string $name, array $props, array $context, stri
 
     public function finishEmbeddedComponentRender(): void
     {
-        try {
-            $this->container->get(ComponentRenderer::class)->finishEmbeddedComponentRender();
-        } catch (\Throwable $e) {
-            $this->throwRuntimeError($name, $e);
-        }
+        $this->container->get(ComponentRenderer::class)->finishEmbeddedComponentRender();
     }
 
     private function throwRuntimeError(string $name, \Throwable $e): void

Original file line number	Diff line number	Diff line change
`@@ -82,11 +82,7 @@ public function embeddedContext(string $name, array $props, array $context, stri`
`82`	`82`
`83`	`83`	`public function finishEmbeddedComponentRender(): void`
`84`	`84`	`{`
`85`		`- try {`
`86`		`- $this->container->get(ComponentRenderer::class)->finishEmbeddedComponentRender();`
`87`		`- } catch (\Throwable $e) {`
`88`		`- $this->throwRuntimeError($name, $e);`
`89`		`- }`
	`85`	`+ $this->container->get(ComponentRenderer::class)->finishEmbeddedComponentRender();`
`90`	`86`	`}`
`91`	`87`
`92`	`88`	`private function throwRuntimeError(string $name, \Throwable $e): void`