replace PHPUnit annotations with attributes

xabbuh · xabbuh · commit a6e850a8a851 · 2025-08-04T09:05:15.000+02:00
diff --git a/Tests/InstantiatorTest.php b/Tests/InstantiatorTest.php
@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\VarExporter\Tests;
 
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\VarExporter\Exception\ClassNotFoundException;
 use Symfony\Component\VarExporter\Exception\NotInstantiableTypeException;
@@ -25,9 +26,7 @@ public function testNotFoundClass()
         Instantiator::instantiate('SomeNotExistingClass');
     }
 
-    /**
-     * @dataProvider provideFailingInstantiation
-     */
+    #[DataProvider('provideFailingInstantiation')]
     public function testFailingInstantiation(string $class)
     {
         $this->expectException(NotInstantiableTypeException::class);
diff --git a/Tests/LazyProxyTraitTest.php b/Tests/LazyProxyTraitTest.php
@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\VarExporter\Tests;
 
+use PHPUnit\Framework\Attributes\RequiresPhp;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Serializer\Mapping\Factory\ClassMetadataFactory;
 use Symfony\Component\Serializer\Mapping\Loader\AttributeLoader;
@@ -31,9 +32,7 @@
 use Symfony\Component\VarExporter\Tests\Fixtures\LazyProxy\TestWakeupClass;
 use Symfony\Component\VarExporter\Tests\Fixtures\SimpleObject;
 
-/**
- * @requires PHP 8.4
- */
+#[RequiresPhp('8.4')]
 class LazyProxyTraitTest extends TestCase
 {
     public function testGetter()
@@ -292,9 +291,7 @@ public function testReinitRegularLazyProxy()
         $this->assertSame(234, $object->foo);
     }
 
-    /**
-     * @requires PHP 8.3
-     */
+    #[RequiresPhp('8.3')]
     public function testReinitReadonlyLazyProxy()
     {
         $object = $this->createLazyProxy(ReadOnlyClass::class, fn () => new ConcreteReadOnlyClass(123));
@@ -306,9 +303,7 @@ public function testReinitReadonlyLazyProxy()
         $this->assertSame(234, $object->foo);
     }
 
-    /**
-     * @requires PHP 8.4
-     */
+    #[RequiresPhp('8.4')]
     public function testConcretePropertyHooks()
     {
         $initialized = false;
@@ -335,9 +330,7 @@ public function testConcretePropertyHooks()
         $this->assertSame(345, $object->backed);
     }
 
-    /**
-     * @requires PHP 8.4
-     */
+    #[RequiresPhp('8.4')]
     public function testAbstractPropertyHooks()
     {
         $initialized = false;
@@ -369,9 +362,7 @@ public function testAbstractPropertyHooks()
         $this->assertTrue($initialized);
     }
 
-    /**
-     * @requires PHP 8.4
-     */
+    #[RequiresPhp('8.4')]
     public function testAsymmetricVisibility()
     {
         $object = $this->createLazyProxy(AsymmetricVisibility::class, function () {
diff --git a/Tests/LegacyLazyGhostTraitTest.php b/Tests/LegacyLazyGhostTraitTest.php
@@ -11,8 +11,10 @@
 
 namespace Symfony\Component\VarExporter\Tests;
 
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\IgnoreDeprecations;
+use PHPUnit\Framework\Attributes\RequiresPhp;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Serializer\Mapping\Factory\ClassMetadataFactory;
 use Symfony\Component\Serializer\Mapping\Loader\AttributeLoader;
@@ -140,9 +142,7 @@ public function testSerialize()
         $this->assertTrue($clone->isLazyObjectInitialized());
     }
 
-    /**
-     * @dataProvider provideMagicClass
-     */
+    #[DataProvider('provideMagicClass')]
     public function testMagicClass(MagicClass $instance)
     {
         $this->assertSame('bar', $instance->foo);
@@ -242,9 +242,7 @@ public function testIndirectModification()
         $this->assertSame([123], $proxy->foo);
     }
 
-    /**
-     * @requires PHP 8.3
-     */
+    #[RequiresPhp('8.3')]
     public function testReadOnlyClass()
     {
         $proxy = $this->createLazyGhost(ReadOnlyClass::class, fn ($proxy) => $proxy->__construct(123));
@@ -298,9 +296,7 @@ public function testReinitLazyGhost()
         $this->assertSame(3, $object->public);
     }
 
-    /**
-     * @requires PHP 8.4
-     */
+    #[RequiresPhp('8.4')]
     public function testPropertyHooks()
     {
         $initialized = false;
@@ -323,9 +319,7 @@ public function testPropertyHooks()
         $this->assertSame(345, $object->backed);
     }
 
-    /**
-     * @requires PHP 8.4
-     */
+    #[RequiresPhp('8.4')]
     public function testPropertyHooksWithDefaultValue()
     {
         $initialized = false;
@@ -351,9 +345,7 @@ public function testPropertyHooksWithDefaultValue()
         $this->assertTrue($object->backedBoolWithDefault);
     }
 
-    /**
-     * @requires PHP 8.4
-     */
+    #[RequiresPhp('8.4')]
     public function testAsymmetricVisibility()
     {
         $object = $this->createLazyGhost(AsymmetricVisibility::class, function ($instance) {
diff --git a/Tests/ProxyHelperTest.php b/Tests/ProxyHelperTest.php
@@ -11,19 +11,17 @@
 
 namespace Symfony\Component\VarExporter\Tests;
 
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\RequiresPhp;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\VarExporter\ProxyHelper;
 use Symfony\Component\VarExporter\Tests\Fixtures\LazyProxy\Hooked;
 use Symfony\Component\VarExporter\Tests\Fixtures\LazyProxy\Php82NullStandaloneReturnType;
 
-/**
- * @requires PHP 8.4
- */
+#[RequiresPhp('8.4')]
 class ProxyHelperTest extends TestCase
 {
-    /**
-     * @dataProvider provideExportSignature
-     */
+    #[DataProvider('provideExportSignature')]
     public function testExportSignature(string $expected, \ReflectionMethod $method)
     {
         $this->assertSame($expected, ProxyHelper::exportSignature($method));
@@ -208,9 +206,7 @@ class_exists(\Symfony\Component\VarExporter\Internal\LazyObjectRegistry::class);
         $this->assertSame($expected, ProxyHelper::generateLazyProxy(null, [new \ReflectionClass(TestForProxyHelperInterface1::class), new \ReflectionClass(TestForProxyHelperInterface2::class)]));
     }
 
-    /**
-     * @dataProvider classWithUnserializeMagicMethodProvider
-     */
+    #[DataProvider('classWithUnserializeMagicMethodProvider')]
     public function testGenerateLazyProxyForClassWithUnserializeMagicMethod(object $obj, string $expected)
     {
         $this->assertStringContainsString($expected, ProxyHelper::generateLazyProxy(new \ReflectionClass($obj::class)));
@@ -282,9 +278,7 @@ public function testNullStandaloneReturnType()
         );
     }
 
-    /**
-     * @requires PHP 8.4
-     */
+    #[RequiresPhp('8.4')]
     public function testPropertyHooks()
     {
         $proxyCode = ProxyHelper::generateLazyProxy(new \ReflectionClass(Hooked::class));
diff --git a/Tests/VarExporterTest.php b/Tests/VarExporterTest.php
@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\VarExporter\Tests;
 
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\VarDumper\Test\VarDumperTestTrait;
 use Symfony\Component\VarExporter\Exception\ClassNotFoundException;
@@ -39,9 +40,7 @@ public function testPhpIncompleteClassesAreForbidden()
         }
     }
 
-    /**
-     * @dataProvider provideFailingSerialization
-     */
+    #[DataProvider('provideFailingSerialization')]
     public function testFailingSerialization($value)
     {
         $this->expectException(NotInstantiableTypeException::class);
@@ -77,9 +76,7 @@ public static function provideFailingSerialization()
         yield [$a];
     }
 
-    /**
-     * @dataProvider provideExport
-     */
+    #[DataProvider('provideExport')]
     public function testExport(string $testName, $value, bool $staticValueExpected = false)
     {
         $dumpedValue = $this->getDump($value);

Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,10 @@`
`11`	`11`
`12`	`12`	`namespace Symfony\Component\VarExporter\Tests;`
`13`	`13`
	`14`	`+use PHPUnit\Framework\Attributes\DataProvider;`
`14`	`15`	`use PHPUnit\Framework\Attributes\Group;`
`15`	`16`	`use PHPUnit\Framework\Attributes\IgnoreDeprecations;`
	`17`	`+use PHPUnit\Framework\Attributes\RequiresPhp;`
`16`	`18`	`use PHPUnit\Framework\TestCase;`
`17`	`19`	`use Symfony\Component\Serializer\Mapping\Factory\ClassMetadataFactory;`
`18`	`20`	`use Symfony\Component\Serializer\Mapping\Loader\AttributeLoader;`
`@@ -140,9 +142,7 @@ public function testSerialize()`
`140`	`142`	`$this->assertTrue($clone->isLazyObjectInitialized());`
`141`	`143`	`}`
`142`	`144`
`143`		`- /**`
`144`		`- * @dataProvider provideMagicClass`
`145`		`- */`
	`145`	`+ #[DataProvider('provideMagicClass')]`
`146`	`146`	`public function testMagicClass(MagicClass $instance)`
`147`	`147`	`{`
`148`	`148`	`$this->assertSame('bar', $instance->foo);`
`@@ -242,9 +242,7 @@ public function testIndirectModification()`
`242`	`242`	`$this->assertSame([123], $proxy->foo);`
`243`	`243`	`}`
`244`	`244`
`245`		`- /**`
`246`		`- * @requires PHP 8.3`
`247`		`- */`
	`245`	`+ #[RequiresPhp('8.3')]`
`248`	`246`	`public function testReadOnlyClass()`
`249`	`247`	`{`
`250`	`248`	`$proxy = $this->createLazyGhost(ReadOnlyClass::class, fn ($proxy) => $proxy->__construct(123));`
`@@ -298,9 +296,7 @@ public function testReinitLazyGhost()`
`298`	`296`	`$this->assertSame(3, $object->public);`
`299`	`297`	`}`
`300`	`298`
`301`		`- /**`
`302`		`- * @requires PHP 8.4`
`303`		`- */`
	`299`	`+ #[RequiresPhp('8.4')]`
`304`	`300`	`public function testPropertyHooks()`
`305`	`301`	`{`
`306`	`302`	`$initialized = false;`
`@@ -323,9 +319,7 @@ public function testPropertyHooks()`
`323`	`319`	`$this->assertSame(345, $object->backed);`
`324`	`320`	`}`
`325`	`321`
`326`		`- /**`
`327`		`- * @requires PHP 8.4`
`328`		`- */`
	`322`	`+ #[RequiresPhp('8.4')]`
`329`	`323`	`public function testPropertyHooksWithDefaultValue()`
`330`	`324`	`{`
`331`	`325`	`$initialized = false;`
`@@ -351,9 +345,7 @@ public function testPropertyHooksWithDefaultValue()`
`351`	`345`	`$this->assertTrue($object->backedBoolWithDefault);`
`352`	`346`	`}`
`353`	`347`
`354`		`- /**`
`355`		`- * @requires PHP 8.4`
`356`		`- */`
	`348`	`+ #[RequiresPhp('8.4')]`
`357`	`349`	`public function testAsymmetricVisibility()`
`358`	`350`	`{`
`359`	`351`	`$object = $this->createLazyGhost(AsymmetricVisibility::class, function ($instance) {`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@`
`11`	`11`
`12`	`12`	`namespace Symfony\Component\VarExporter\Tests;`
`13`	`13`
	`14`	`+use PHPUnit\Framework\Attributes\DataProvider;`
`14`	`15`	`use PHPUnit\Framework\TestCase;`
`15`	`16`	`use Symfony\Component\VarDumper\Test\VarDumperTestTrait;`
`16`	`17`	`use Symfony\Component\VarExporter\Exception\ClassNotFoundException;`
`@@ -39,9 +40,7 @@ public function testPhpIncompleteClassesAreForbidden()`
`39`	`40`	`}`
`40`	`41`	`}`
`41`	`42`
`42`		`- /**`
`43`		`- * @dataProvider provideFailingSerialization`
`44`		`- */`
	`43`	`+ #[DataProvider('provideFailingSerialization')]`
`45`	`44`	`public function testFailingSerialization($value)`
`46`	`45`	`{`
`47`	`46`	`$this->expectException(NotInstantiableTypeException::class);`
`@@ -77,9 +76,7 @@ public static function provideFailingSerialization()`
`77`	`76`	`yield [$a];`
`78`	`77`	`}`
`79`	`78`
`80`		`- /**`
`81`		`- * @dataProvider provideExport`
`82`		`- */`
	`79`	`+ #[DataProvider('provideExport')]`
`83`	`80`	`public function testExport(string $testName, $value, bool $staticValueExpected = false)`
`84`	`81`	`{`
`85`	`82`	`$dumpedValue = $this->getDump($value);`