feat: add generation cancellation to AI chat #140
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What:** - Add user-initiated cancellation for AI generation streams - Visual feedback for incomplete/cancelled messages - Comprehensive test coverage **Changes:** - Add property to Message interface - Enhance function with AbortController support - Add cancellation state management to Chat component - Update ChatWaiting with cancel button and callback - Add visual feedback (75% opacity + ... indicator) for cancelled messages **Testing:** - Unit tests for cancellation logic - Component tests for UI behavior - All 13 tests passing **Related:** #89 (Allow cancelling generations)
Run report for 0f4aebdb
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| ⬛️ | SetupProto(0.53.2) |
0.1ms | Skipped | |
| 🟩 | SyncWorkspace |
7.8ms | Passed | |
| 🟩 | SyncProject(frontend) |
0.7ms | Passed | |
| ⬛️ | SetupToolchain(node:~24) |
1.6s | Skipped | |
| 🟩 | InstallWorkspaceDeps(node:~24) |
6.8s | Passed | |
| 🟩 | RunTask(frontend:test) |
22.2s | Passed | |
| 🟩 | RunTask(frontend:build) |
34s | Passed | |
| 🟩 | RunTask(frontend:install-playwright) |
43s | Passed | |
| 🟩 | RunTask(frontend:test-e2e) |
5s | Passed |
Environment
OS: Linux
Matrix:
index = 1
Touched files
apps/frontend/src/lib/components/Chat.svelte
apps/frontend/src/lib/components/Chat.test.ts
apps/frontend/src/lib/components/ChatMessage.svelte
apps/frontend/src/lib/components/ChatMessages.svelte
apps/frontend/src/lib/components/ChatWaiting.svelte
apps/frontend/src/lib/components/ChatWaiting.svelte.test.ts
apps/frontend/src/lib/langgraph/streamAnswer.ts
apps/frontend/src/lib/langgraph/types.ts
Run report for 0f4aebdb
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| ⬛️ | SetupProto(0.53.2) |
0ms | Skipped | |
| 🟩 | SyncWorkspace |
8.2ms | Passed | |
| 🟩 | SyncProject(frontend) |
0.6ms | Passed | |
| ⬛️ | SetupToolchain(node:~24) |
1.5s | Skipped | |
| 🟩 | InstallWorkspaceDeps(node:~24) |
6.4s | Passed | |
| 🟥 | RunTask(frontend:lint) |
21.5s | Failed | |
| 🟥 | RunTask(frontend:format) |
3.4s | Failed | |
| 🟩 | RunTask(frontend:test-cov) |
29.8s | Passed | |
| 🟩 | RunTask(frontend:build) |
42.7s | Passed | |
| 🟩 | RunTask(frontend:install-playwright) |
43.6s | Passed | |
| 🟩 | RunTask(frontend:test-e2e) |
5.5s | Passed | |
| 🟩 | RunTask(frontend:check) |
16.3s | Passed |
Environment
OS: Linux
Matrix:
index = 0
Touched files
apps/frontend/src/lib/components/Chat.svelte
apps/frontend/src/lib/components/Chat.test.ts
apps/frontend/src/lib/components/ChatMessage.svelte
apps/frontend/src/lib/components/ChatMessages.svelte
apps/frontend/src/lib/components/ChatWaiting.svelte
apps/frontend/src/lib/components/ChatWaiting.svelte.test.ts
apps/frontend/src/lib/langgraph/streamAnswer.ts
apps/frontend/src/lib/langgraph/types.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds user-initiated cancellation functionality for AI generation streams with comprehensive visual feedback and testing.
Changes
Testing
Related
Fixes #89 - Allow cancelling generations
Quality Checks