Remove the redundant code

NOVBobLee · NOVBobLee · commit 8c641a2deb4c · 2024-10-06T14:25:49.000+08:00
proc_remove does nothing when the argument is NULL[1]. We don't need proc_remove after proc_create failed. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/proc/generic.c#n789
diff --git a/examples/procfs1.c b/examples/procfs1.c
@@ -48,7 +48,6 @@ static int __init procfs1_init(void)
 {
     our_proc_file = proc_create(procfs_name, 0644, NULL, &proc_file_fops);
     if (NULL == our_proc_file) {
-        proc_remove(our_proc_file);
         pr_alert("Error:Could not initialize /proc/%s\n", procfs_name);
         return -ENOMEM;
     }

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,6 @@ static int __init procfs1_init(void)`
`48`	`48`	`{`
`49`	`49`	`our_proc_file = proc_create(procfs_name, 0644, NULL, &proc_file_fops);`
`50`	`50`	`if (NULL == our_proc_file) {`
`51`		`- proc_remove(our_proc_file);`
`52`	`51`	`pr_alert("Error:Could not initialize /proc/%s\n", procfs_name);`
`53`	`52`	`return -ENOMEM;`
`54`	`53`	`}`