Fix undefined behavior in RV_MARCHID definition

visitorckw · visitorckw · commit b790a3376929 · 2024-01-09T05:41:55.000+08:00
The RV_MARCHID macro is defined using a left shift operation without
explicitly specifying the type of the constant. This can lead to
undefined behavior, specifically a shift too many bits issue.

Modify the RV_MARCHID definition to use the ULL suffix for the
constant, ensuring it is treated as an unsigned long long. This
eliminates the undefined behavior.
diff --git a/main.c b/main.c
@@ -185,7 +185,7 @@ static inline sbi_ret_t handle_sbi_ecall_RST(vm_t *vm, int32_t fid)
 }
 
 #define RV_MVENDORID 0x12345678
-#define RV_MARCHID ((1 << 31) | 1)
+#define RV_MARCHID ((1ULL << 31) | 1)
 #define RV_MIMPID 1
 
 static inline sbi_ret_t handle_sbi_ecall_BASE(vm_t *vm, int32_t fid)

Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ static inline sbi_ret_t handle_sbi_ecall_RST(vm_t *vm, int32_t fid)`
`185`	`185`	`}`
`186`	`186`
`187`	`187`	`#define RV_MVENDORID 0x12345678`
`188`		`-#define RV_MARCHID ((1 << 31) \| 1)`
	`188`	`+#define RV_MARCHID ((1ULL << 31) \| 1)`
`189`	`189`	`#define RV_MIMPID 1`
`190`	`190`
`191`	`191`	`static inline sbi_ret_t handle_sbi_ecall_BASE(vm_t *vm, int32_t fid)`