Fix issues

Author: takos22

codingame/client/async_.py

@@ -153,20 +153,31 @@ async def create_private_clash_of_code(
             )
         except HTTPError as error:
             if error.data["id"] in (500, 501):
-                raise LoginRequired() from None
+                raise LoginRequired(error.data.get("message", "")) from None
             raise  # pragma: no cover
 
         return await self.get_clash_of_code(data["publicHandle"])
 
-    async def join_private_clash_of_code(self, handle: str) -> ClashOfCode:
+    async def join_private_clash_of_code(
+        self, clash_of_code: typing.Union[ClashOfCode, str]
+    ) -> ClashOfCode:
+        if not self.logged_in:
+            raise LoginRequired()
+
+        handle = (
+            clash_of_code
+            if isinstance(clash_of_code, str)
+            else clash_of_code.public_handle
+        )
+
         if not CLASH_OF_CODE_HANDLE_REGEX.match(handle):
             raise ValueError(
                 f"Clash of Code handle {handle!r} isn't in the good format "
                 "(regex: [0-9]{7}[0-9a-f]{32})."
             )
 
         try:
-            data = await self._state.http.join_clash_of_code_by_handle(
+            await self._state.http.join_clash_of_code_by_handle(
                 self.codingamer.id, handle
             )
         except HTTPError as error:
@@ -181,7 +192,7 @@ async def join_private_clash_of_code(self, handle: str) -> ClashOfCode:
                 )
 
             raise  # pragma: no cover
-        return ClashOfCode(self._state, data)
+        return await self.get_clash_of_code(handle)
 
     # --------------------------------------------------------------------------
     # Language IDs

codingame/client/base.py

@@ -340,9 +340,8 @@ def join_private_clash_of_code(self, handle: str) -> "ClashOfCode":
 
         Parameters
         -----------
-            handle: :class:`str`
-                The Clash of Code's public handle. 39 character long hexadecimal
-                string (regex: ``[0-9]{7}[0-9a-f]{32}``).
+            handle: :class:`~codingame.ClashOfCode` or :class:`str`
+                The Clash of Code to join or its public handle.
 
         Raises
         ------

codingame/client/sync.py

@@ -148,20 +148,31 @@ def create_private_clash_of_code(
             )
         except HTTPError as error:
             if error.data["id"] in (500, 501):
-                raise LoginRequired() from None
+                raise LoginRequired(error.data.get("message", "")) from None
             raise  # pragma: no cover
 
         return self.get_clash_of_code(data["publicHandle"])
 
-    def join_private_clash_of_code(self, handle: str) -> ClashOfCode:
+    def join_private_clash_of_code(
+        self, clash_of_code: typing.Union[ClashOfCode, str]
+    ) -> ClashOfCode:
+        if not self.logged_in:
+            raise LoginRequired()
+
+        handle = (
+            clash_of_code
+            if isinstance(clash_of_code, str)
+            else clash_of_code.public_handle
+        )
+
         if not CLASH_OF_CODE_HANDLE_REGEX.match(handle):
             raise ValueError(
                 f"Clash of Code handle {handle!r} isn't in the good format "
                 "(regex: [0-9]{7}[0-9a-f]{32})."
             )
 
         try:
-            data = self._state.http.join_clash_of_code_by_handle(
+            self._state.http.join_clash_of_code_by_handle(
                 self.codingamer.id, handle
             )
         except HTTPError as error:
@@ -176,7 +187,7 @@ def join_private_clash_of_code(self, handle: str) -> ClashOfCode:
                 )
 
             raise  # pragma: no cover
-        return ClashOfCode(self._state, data)
+        return self.get_clash_of_code(handle)
 
     # --------------------------------------------------------------------------
     # Language IDs