Skip to content

[TASK] Expose fields getter for Note inner JsNote #244

@AhmedKorim

Description

@AhmedKorim

Overview

The current Note class doesn't expose the inner JsNote fields, to reach those data the user has to access the inner type
The goal here is to expose the inner type fields

Spec

Fields to expose

Fields are defined in the inner type JsNote after building packages/wasm-utils/build/wasm-utils.d.ts

Getters

 get HashFunction () {
   return this.note.hashFunction ;
 }
 

for importing types from wasm-utils use import type {xxx} from '@webb-tools/wasm-utils
EX import type {HashFunction} from '@webb-tools/wasm-utils'

Tests

Similar to the tests we have in the note.spec.ts packages/sdk-core/src/__test__/note.spec.ts, Add a test that leverages those getters and insure that the values are correct

Metadata

Metadata

Assignees

No one assigned

    Labels

    p3 🔵Issues should be resolved eventuallyspec 🆕Specification details for future implementation

    Type

    No type

    Projects

    Status

    Not Started 🕧

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions