Skip to content

Commit 95b0329

Browse files
authored
Merge pull request #74 from tangrams/enum-popup
Use better API enum popup
2 parents a9f87ef + bb826ea commit 95b0329

File tree

2 files changed

+2
-24
lines changed

2 files changed

+2
-24
lines changed

Assets/Editor/PolygonBuilderEditor.cs

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ public class PolygonBuilderEditor : EditorBase
1111
[SerializeField]
1212
private bool show;
1313

14-
[SerializeField]
15-
private int selectedExtrusionType = -1;
16-
1714
public PolygonBuilderEditor()
1815
: base()
1916
{
@@ -53,16 +50,8 @@ public PolygonBuilder.Options OnInspectorGUI(PolygonBuilder.Options options)
5350
return options;
5451
}
5552

56-
if (selectedExtrusionType == -1)
57-
{
58-
selectedExtrusionType = (int) options.Extrusion;
59-
}
60-
6153
options.MaxHeight = EditorGUILayout.FloatField("Max Height: ", options.MaxHeight);
62-
var extrusionTypeList = Enum.GetValues(typeof(PolygonBuilder.ExtrusionType)).Cast<PolygonBuilder.ExtrusionType>();
63-
var extrusionTypeStringList = extrusionTypeList.Select(type => type.ToString());
64-
selectedExtrusionType = EditorGUILayout.Popup("Extrusion type: ", selectedExtrusionType, extrusionTypeStringList.ToArray());
65-
options.Extrusion = (PolygonBuilder.ExtrusionType) selectedExtrusionType;
54+
options.Extrusion = (PolygonBuilder.ExtrusionType)EditorGUILayout.EnumPopup("Extrusion type: ", options.Extrusion);
6655
options.Enabled = EditorGUILayout.Toggle("Enabled: ", options.Enabled);
6756

6857
SavePreferences();

Assets/Editor/PolylineBuilderEditor.cs

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ public class PolylineBuilderEditor : EditorBase
1111
[SerializeField]
1212
private bool show;
1313

14-
[SerializeField]
15-
private int selectedExtrusionType = -1;
16-
1714
public PolylineBuilderEditor()
1815
: base()
1916
{
@@ -55,17 +52,9 @@ public PolylineBuilder.Options OnInspectorGUI(PolylineBuilder.Options options)
5552
return options;
5653
}
5754

58-
if (selectedExtrusionType == -1)
59-
{
60-
selectedExtrusionType = (int) options.Extrusion;
61-
}
62-
6355
options.Width = EditorGUILayout.FloatField("Width: ", options.Width);
6456
options.MaxHeight = EditorGUILayout.FloatField("Max Height: ", options.MaxHeight);
65-
var extrusionTypeList = Enum.GetValues(typeof(PolygonBuilder.ExtrusionType)).Cast<PolygonBuilder.ExtrusionType>();
66-
var extrusionTypeStringList = extrusionTypeList.Select(type => type.ToString());
67-
selectedExtrusionType = EditorGUILayout.Popup("Extrusion type:", selectedExtrusionType, extrusionTypeStringList.ToArray());
68-
options.Extrusion = (PolygonBuilder.ExtrusionType) selectedExtrusionType;
57+
options.Extrusion = (PolygonBuilder.ExtrusionType)EditorGUILayout.EnumPopup("Extrusion type: ", options.Extrusion);
6958
options.Enabled = EditorGUILayout.Toggle("Enabled: ", options.Enabled);
7059

7160
SavePreferences();

0 commit comments

Comments
 (0)