From fbff53fcba7856268f57ba2b70bc6c21225842e0 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Mon, 27 Jul 2026 18:43:39 +0000
Subject: [PATCH] Add the shared pull-request template (taphouse sync)

Synced from the canonical TapHouse copy: the family's shared review prompts --
what changed and why, a Verification section asking what was actually built and
run versus what CI will gate (plus the measured-not-remembered rule for
performance claims), and a delete-what-does-not-apply list of the recurring
cross-repo concerns: contract changes, submodule pin flow, notebook
re-execution, package docs/help and universal binaries, and documented per-repo
exceptions.

Created only-if-missing and deliberately NOT drift-guarded, following the
.claude/settings.json precedent: it is prose for humans rather than a
machine-enforced config, so this repo is free to tailor it -- trim the bullets
that do not apply here.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JhhQ93r2E1QTnCx46YfX8j
---
 .github/pull_request_template.md | 40 ++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 .github/pull_request_template.md

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 0000000..8723f79
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,40 @@
+## What this changes
+
+<!-- One or two sentences. Link the issue if there is one. -->
+
+## Why
+
+<!-- The problem this solves, not a restatement of the diff. -->
+
+## Verification
+
+<!-- What you actually built and ran, and what you did not — state the gap
+     plainly rather than leaving it to be inferred. If CI is the first real
+     gate for part of this change, say so.
+
+     Every performance claim cites the executed notebook cell or the pinned
+     test that carries the number: measured, not remembered. -->
+
+## Notes for the reviewer
+
+<!-- Delete the lines that do not apply; add anything that surprised you.
+
+  - **Contract change.** A documented contract point moved — packing,
+    conventions, normalization, latency, a Q format, a default. This is
+    breaking for every consumer; say which ones.
+  - **Submodule pin moved.** Which pin, and why. After this merges by
+    rebase/squash, repoint any open consumer pins at the identical tree on
+    `main` so they stay reachable once the branch is deleted.
+  - **Notebooks re-executed**, because behavior changed. They are committed
+    executed.
+  - **Style configs** came from a `taphouse` sync, not a hand-edit. A
+    hand-edited copy fails the drift job by design.
+  - **Canonical TapHouse file changed.** Tag it, then re-sync consumers —
+    merge here first, since a guarded unconditional file must exist at the
+    pinned ref before a consumer references it.
+  - **Max/Pd package.** Reference page and help patcher ship for each new
+    object; the macOS binary is still universal (arm64 + x86_64).
+  - **Documented exception.** This repo diverges from a house rule on
+    purpose (see its `.clang-tidy` / `STYLE.md` note) and this change keeps
+    that divergence intact.
+-->