Skip to content

Commit 1b133f3

Browse files
dereference23vbajs
authored andcommitted
Revert "sched: fair: Add strict skip buddy support"
This reverts commit 6f58caa. It's not present in newer CAF kernels and Google removed it on their 4.14 devices as well. Change-Id: I3675cbfe4a37ae9ed31bf3659a545965a0d59c6f Signed-off-by: Alexander Winkowski <dereference23@outlook.com> Signed-off-by: Yahya Wessam <yahyawessam2002@gmail.com>
1 parent f267276 commit 1b133f3

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

kernel/sched/fair.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4227,7 +4227,6 @@ pick_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *curr)
42274227
{
42284228
struct sched_entity *left = __pick_first_entity(cfs_rq);
42294229
struct sched_entity *se;
4230-
bool strict_skip = false;
42314230

42324231
/*
42334232
* If curr is set we have to see if its left of the leftmost entity
@@ -4247,16 +4246,13 @@ pick_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *curr)
42474246

42484247
if (se == curr) {
42494248
second = __pick_first_entity(cfs_rq);
4250-
if (sched_feat(STRICT_SKIP_BUDDY))
4251-
strict_skip = true;
42524249
} else {
42534250
second = __pick_next_entity(se);
42544251
if (!second || (curr && entity_before(curr, second)))
42554252
second = curr;
42564253
}
42574254

4258-
if (second && (strict_skip ||
4259-
wakeup_preempt_entity(second, left) < 1))
4255+
if (second && wakeup_preempt_entity(second, left) < 1)
42604256
se = second;
42614257
}
42624258

kernel/sched/features.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,6 @@
2626
*/
2727
#define SCHED_FEAT_LAST_BUDDY 1
2828

29-
/*
30-
* skip buddy i.e task called yield() is always skipped and the
31-
* next entity is selected to run irrespective of the vruntime
32-
*/
33-
SCHED_FEAT(STRICT_SKIP_BUDDY, true)
34-
3529
/*
3630
* Consider buddies to be cache hot, decreases the likelyness of a
3731
* cache buddy being migrated away, increases cache locality.

0 commit comments

Comments
 (0)