Skip to content

Commit e6a58ff

Browse files
Syed Rameez Mustafavbajs
authored andcommitted
sched/features: Turn off the TTWU_QUEUE feature
While the feature TTWU_QUEUE has the advantage of reducing cache bouncing of runqueue locks, it has the side effect that runqueue statistics are not updated until the remote CPU has a chance to enqueue the task. Since there is no upper bound on the amount of time it can take the remote CPU to enqueue the task, several sequential wakeups can result in suboptimal task placement based on the stale statistics. Turn off the feature as the cost of sub-optimal placement is much higher than the cost of cache bouncing spinlocks for msm based systems. Change-Id: I0b85c0225237b2bc44f54934769f5e3750c0f3d6 Signed-off-by: Syed Rameez Mustafa <rameezmustafa@codeaurora.org> [pkondeti@codeaurora.org: Resolved minor merge conflict] Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org> Signed-off-by: Forenche <prahul2003@gmail.com> Signed-off-by: Richard Raya <rdxzv.dev@gmail.com> [vbajs: This reverts commit 3307013.] Signed-off-by: Yahya Wessam <yahyawessam2002@gmail.com>
1 parent cb8dc63 commit e6a58ff

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/sched/features.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
* Queue remote wakeups on the target CPU and process them
5050
* using the scheduler IPI. Reduces rq->lock contention/bounces.
5151
*/
52-
#define SCHED_FEAT_TTWU_QUEUE 1
52+
#define SCHED_FEAT_TTWU_QUEUE 0
5353

5454
/*
5555
* When doing wakeups, attempt to limit superfluous scans of the LLC domain.

0 commit comments

Comments
 (0)