Skip to content

Commit 3dbef5b

Browse files
authored
Merge pull request #405 from teamterning/refactor/#402
[REFACTOR/#402] 유빈 뷰 / 리팩토링
2 parents fa29ccd + 68f88cb commit 3dbef5b

File tree

30 files changed

+172
-138
lines changed

30 files changed

+172
-138
lines changed

core/designsystem/src/main/java/com/terning/core/designsystem/component/button/DeleteRoundButton.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ fun DeleteRoundButton(
7070

7171
@Preview(showBackground = true)
7272
@Composable
73-
fun DeleteRoundButtonPreview() {
73+
private fun DeleteRoundButtonPreview() {
7474
TerningPointTheme {
7575
DeleteRoundButton(
7676
style = TextStyle(),

core/designsystem/src/main/java/com/terning/core/designsystem/component/button/FilteringButton.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ fun FilteringButton(
101101

102102
@Preview(showBackground = true)
103103
@Composable
104-
fun FilteringButtonPreview() {
104+
private fun FilteringButtonPreview() {
105105
TerningPointTheme {
106106
Column {
107107
FilteringButton(

core/designsystem/src/main/java/com/terning/core/designsystem/component/image/TerningImage.kt

Lines changed: 0 additions & 38 deletions
This file was deleted.

core/designsystem/src/main/java/com/terning/core/designsystem/component/item/ProfileWithPlusButton.kt

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,24 @@ import androidx.compose.ui.res.painterResource
1414
import androidx.compose.ui.tooling.preview.Preview
1515
import androidx.compose.ui.unit.dp
1616
import com.terning.core.designsystem.R
17+
import com.terning.core.designsystem.extension.noRippleClickable
18+
import com.terning.core.designsystem.theme.TerningPointTheme
1719
import com.terning.core.designsystem.type.ProfileImage
1820

1921
@Composable
2022
fun ProfileWithPlusButton(
2123
profileImage: String,
24+
onClick: (Boolean) -> Unit,
2225
modifier: Modifier = Modifier,
2326
) {
2427
val userProfile = ProfileImage.fromString(profileImage)
2528

2629
Box(
27-
modifier = modifier.wrapContentWidth()
30+
modifier = modifier
31+
.wrapContentWidth()
32+
.noRippleClickable {
33+
onClick(true)
34+
}
2835
) {
2936
Image(
3037
painterResource(id = userProfile.drawableResId),
@@ -44,6 +51,11 @@ fun ProfileWithPlusButton(
4451

4552
@Preview(showBackground = true)
4653
@Composable
47-
fun ProfileWithPlusButtonPreview() {
48-
ProfileWithPlusButton(profileImage = "basic")
54+
private fun ProfileWithPlusButtonPreview() {
55+
TerningPointTheme {
56+
ProfileWithPlusButton(
57+
profileImage = "basic",
58+
onClick = {}
59+
)
60+
}
4961
}

core/network/build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,5 +62,4 @@ dependencies {
6262
implementation(libs.process.phoenix)
6363
implementation(libs.bundles.retrofit)
6464
implementation(libs.bundles.okhttp)
65-
implementation(platform(libs.okhttp.bom))
6665
}

feature/filtering/src/main/java/com/terning/feature/filtering/filteringone/FilteringOneRoute.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import com.terning.feature.filtering.R
3131
import com.terning.feature.filtering.filteringone.component.StatusOneRadioGroup
3232

3333
@Composable
34-
fun FilteringOneRoute(
34+
internal fun FilteringOneRoute(
3535
name: String,
3636
onNextClick: (String) -> Unit,
3737
navigateUp: () -> Unit,
@@ -73,7 +73,7 @@ fun FilteringOneRoute(
7373
}
7474

7575
@Composable
76-
fun FilteringOneScreen(
76+
private fun FilteringOneScreen(
7777
name: String,
7878
onNextClick: (String) -> Unit,
7979
navigateUp: () -> Unit,
@@ -153,7 +153,7 @@ fun FilteringOneScreen(
153153

154154
@Preview(showBackground = true)
155155
@Composable
156-
fun FilteringOneScreenPreview() {
156+
private fun FilteringOneScreenPreview() {
157157
TerningPointTheme {
158158
FilteringOneScreen(
159159
name = "터닝이",

feature/filtering/src/main/java/com/terning/feature/filtering/filteringone/component/StatusOneRadioGroup.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import com.terning.core.designsystem.type.Grade
1616
import com.terning.feature.filtering.R
1717

1818
@Composable
19-
fun StatusOneRadioGroup(
19+
internal fun StatusOneRadioGroup(
2020
onButtonClick: (String) -> Unit,
2121
modifier: Modifier = Modifier,
2222
) {

feature/filtering/src/main/java/com/terning/feature/filtering/filteringthree/FilteringThreeRoute.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ import com.terning.feature.filtering.filteringthree.component.FilteringYearMonth
3939
import java.util.Calendar
4040

4141
@Composable
42-
fun FilteringThreeRoute(
42+
internal fun FilteringThreeRoute(
4343
grade: String,
4444
workingPeriod: String,
4545
navigateUp: () -> Unit,
@@ -101,7 +101,7 @@ fun FilteringThreeRoute(
101101
}
102102

103103
@Composable
104-
fun FilteringThreeScreen(
104+
private fun FilteringThreeScreen(
105105
navigateUp: () -> Unit,
106106
chosenYear: Int,
107107
chosenMonth: Int,
@@ -167,7 +167,7 @@ fun FilteringThreeScreen(
167167

168168
@Preview(showBackground = true)
169169
@Composable
170-
fun FilteringThreeScreenPreview() {
170+
private fun FilteringThreeScreenPreview() {
171171
TerningPointTheme {
172172
FilteringThreeScreen(
173173
navigateUp = { },

feature/filtering/src/main/java/com/terning/feature/filtering/filteringthree/component/FilteringYearMonthPicker.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,10 @@ import com.terning.core.designsystem.util.CalendarDefaults.END_MONTH
3838
import com.terning.core.designsystem.util.CalendarDefaults.END_YEAR
3939
import com.terning.core.designsystem.util.CalendarDefaults.START_MONTH
4040
import com.terning.core.designsystem.util.CalendarDefaults.START_YEAR
41+
import kotlinx.collections.immutable.ImmutableList
42+
import kotlinx.collections.immutable.toImmutableList
4143
import kotlinx.coroutines.flow.distinctUntilChanged
4244
import kotlinx.coroutines.flow.map
43-
import okhttp3.internal.toImmutableList
4445

4546
private val years =
4647
(START_YEAR..END_YEAR).map { "${it}" }.toImmutableList()
@@ -107,7 +108,7 @@ fun FilteringYearMonthPicker(
107108

108109
@Composable
109110
fun DatePicker(
110-
items: List<String>,
111+
items: ImmutableList<String>,
111112
modifier: Modifier = Modifier,
112113
pickerState: PickerState = rememberPickerState(),
113114
startIndex: Int = 0,

feature/filtering/src/main/java/com/terning/feature/filtering/filteringtwo/FilteringTwoRoute.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import com.terning.feature.filtering.R
3131
import com.terning.feature.filtering.filteringtwo.component.StatusTwoRadioGroup
3232

3333
@Composable
34-
fun FilteringTwoRoute(
34+
internal fun FilteringTwoRoute(
3535
grade: String,
3636
onNextClick: (String, String) -> Unit,
3737
navigateUp: () -> Unit,
@@ -76,7 +76,7 @@ fun FilteringTwoRoute(
7676
}
7777

7878
@Composable
79-
fun FilteringTwoScreen(
79+
private fun FilteringTwoScreen(
8080
grade: String,
8181
onNextClick: (String, String) -> Unit,
8282
navigateUp: () -> Unit,
@@ -142,7 +142,7 @@ fun FilteringTwoScreen(
142142

143143
@Preview(showBackground = true)
144144
@Composable
145-
fun FilteringTwoScreenPreview() {
145+
private fun FilteringTwoScreenPreview() {
146146
TerningPointTheme {
147147
FilteringTwoScreen(
148148
grade = "freshman",

0 commit comments

Comments
 (0)