From 07702b1bc0ec86ad213848ac8833779eb1247034 Mon Sep 17 00:00:00 2001
From: "jihoon.park" <jihoon.park@rgpkorea.co.kr>
Date: Wed, 6 Sep 2017 12:26:12 +0900
Subject: [PATCH 1/7] Add functionality for setting rating by touch move.
 minRating attribute is added.

---
 app/build.gradle                              |  2 +-
 app/src/main/res/layout/content_main.xml      |  6 +-
 build.gradle                                  |  2 +-
 gradle/wrapper/gradle-wrapper.properties      |  4 +-
 library/build.gradle                          |  2 +-
 library/res/values/attrs.xml                  |  6 +-
 .../properratingbar/ProperRatingBar.java      | 64 ++++++++++++++-----
 7 files changed, 57 insertions(+), 29 deletions(-)

diff --git a/app/build.gradle b/app/build.gradle
index 7ba00d2..03d2017 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -2,7 +2,7 @@ apply plugin: 'com.android.application'
 
 android {
     compileSdkVersion 23
-    buildToolsVersion "23.0.2"
+    buildToolsVersion '25.0.0'
 
     defaultConfig {
         applicationId "io.techery.properratingbar.sample"
diff --git a/app/src/main/res/layout/content_main.xml b/app/src/main/res/layout/content_main.xml
index 5e8f1b2..cf74c49 100644
--- a/app/src/main/res/layout/content_main.xml
+++ b/app/src/main/res/layout/content_main.xml
@@ -34,8 +34,7 @@
         app:prb_symbolicTick="$"
         app:prb_symbolicTickNormalColor="@android:color/darker_gray"
         app:prb_symbolicTickSelectedColor="@android:color/holo_green_dark"
-        app:prb_totalTicks="5"
-        />
+        app:prb_totalTicks="5" />
 
     <Button
         android:id="@+id/toggleTick"
@@ -59,12 +58,13 @@
         android:layout_height="wrap_content"
         android:layout_gravity="center_horizontal"
         android:layout_margin="@dimen/sample_default_margin"
+        android:clickable="true"
         app:prb_defaultRating="4"
         app:prb_tickNormalDrawable="@drawable/ic_star_normal"
         app:prb_tickSelectedDrawable="@drawable/ic_star_selected"
         app:prb_tickSpacing="@dimen/sample_prb_tick_spacing"
         app:prb_totalTicks="7"
-        app:prb_clickable="true"
+        app:prb_minRating="1"
         />
 
     <LinearLayout
diff --git a/build.gradle b/build.gradle
index 03bced9..c2eea8e 100644
--- a/build.gradle
+++ b/build.gradle
@@ -5,7 +5,7 @@ buildscript {
         jcenter()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:2.1.0'
+        classpath 'com.android.tools.build:gradle:2.3.3'
 
         // NOTE: Do not place your application dependencies here; they belong
         // in the individual module build.gradle files
diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties
index 6ea74fc..6579125 100644
--- a/gradle/wrapper/gradle-wrapper.properties
+++ b/gradle/wrapper/gradle-wrapper.properties
@@ -1,6 +1,6 @@
-#Tue Oct 13 16:58:22 EEST 2015
+#Wed Sep 06 11:53:55 KST 2017
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-2.10-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-all.zip
diff --git a/library/build.gradle b/library/build.gradle
index 67f4cd5..1062418 100644
--- a/library/build.gradle
+++ b/library/build.gradle
@@ -5,7 +5,7 @@ group = "io.techery"
 android {
 
     compileSdkVersion 23
-    buildToolsVersion "23.0.2"
+    buildToolsVersion '25.0.0'
 
     defaultConfig {
         minSdkVersion 14
diff --git a/library/res/values/attrs.xml b/library/res/values/attrs.xml
index 99a16cf..baff9e6 100644
--- a/library/res/values/attrs.xml
+++ b/library/res/values/attrs.xml
@@ -33,9 +33,8 @@
         <!-- Use this to set rating from xml. Default is '3' -->
         <attr name="prb_defaultRating" format="integer" />
 
-        <!-- If set to 'true' - use will be able to change rating by clicking. Default is 'false' -->
-        <attr name="prb_clickable" format="boolean" />
-
+        <!-- User this to set minimum rating. Default is '0' -->
+        <attr name="prb_minRating" format="integer" />
 
         <!-- Symbol to be used as a tick. Default is '$' -->
         <attr name="prb_symbolicTick" format="string" />
@@ -52,7 +51,6 @@
         <!-- Color of symbolic tick that is selected (rated). Default is '#FF888888' (gray). -->
         <attr name="prb_symbolicTickSelectedColor" format="reference|color" />
 
-
         <!-- Drawable resource to use as a tick that is not selected (not rated). No default value. -->
         <attr name="prb_tickNormalDrawable" format="reference" />
 
diff --git a/library/src/io/techery/properratingbar/ProperRatingBar.java b/library/src/io/techery/properratingbar/ProperRatingBar.java
index 773730e..3f9815f 100644
--- a/library/src/io/techery/properratingbar/ProperRatingBar.java
+++ b/library/src/io/techery/properratingbar/ProperRatingBar.java
@@ -9,6 +9,7 @@
 import android.os.Parcelable;
 import android.util.AttributeSet;
 import android.util.TypedValue;
+import android.view.MotionEvent;
 import android.view.View;
 import android.widget.ImageView;
 import android.widget.LinearLayout;
@@ -45,8 +46,8 @@ of this software and associated documentation files (the "Software"), to deal
 public class ProperRatingBar extends LinearLayout {
 
     private static final int DF_TOTAL_TICKS = 5;
-    private static final int DF_DEFAULT_TICKS = 3;
-    private static final boolean DF_CLICKABLE = false;
+    private static final int DF_DEFAULT_RATING = 3;
+    private static final int DF_MIN_RATING = 0;
     private static final int DF_SYMBOLIC_TICK_RES = R.string.prb_default_symbolic_string;
     private static final int DF_SYMBOLIC_TEXT_SIZE_RES = R.dimen.prb_symbolic_tick_default_text_size;
     private static final int DF_SYMBOLIC_TEXT_STYLE = Typeface.NORMAL;
@@ -56,7 +57,6 @@ public class ProperRatingBar extends LinearLayout {
 
     private int totalTicks;
     private int lastSelectedTickIndex;
-    private boolean clickable;
     private String symbolicTick;
     private int customTextSize;
     private int customTextStyle;
@@ -68,6 +68,7 @@ public class ProperRatingBar extends LinearLayout {
 
     private boolean useSymbolicTick = false;
     private int rating;
+    private int minRating;
     private RatingListener listener = null;
 
     public ProperRatingBar(Context context, AttributeSet attrs) {
@@ -79,9 +80,8 @@ private void init(Context context, AttributeSet attrs) {
         TypedArray a = context.obtainStyledAttributes(attrs, R.styleable.ProperRatingBar);
         //
         totalTicks = a.getInt(R.styleable.ProperRatingBar_prb_totalTicks, DF_TOTAL_TICKS);
-        rating = a.getInt(R.styleable.ProperRatingBar_prb_defaultRating, DF_DEFAULT_TICKS);
-        //
-        clickable = a.getBoolean(R.styleable.ProperRatingBar_prb_clickable, DF_CLICKABLE);
+        rating = a.getInt(R.styleable.ProperRatingBar_prb_defaultRating, DF_DEFAULT_RATING);
+        minRating = a.getInt(R.styleable.ProperRatingBar_prb_minRating, DF_MIN_RATING);
         //
         symbolicTick = a.getString(R.styleable.ProperRatingBar_prb_symbolicTick);
         if (symbolicTick == null) symbolicTick = context.getString(DF_SYMBOLIC_TICK_RES);
@@ -98,6 +98,7 @@ private void init(Context context, AttributeSet attrs) {
         tickSelectedDrawable = a.getDrawable(R.styleable.ProperRatingBar_prb_tickSelectedDrawable);
         tickSpacing = a.getDimensionPixelOffset(R.styleable.ProperRatingBar_prb_tickSpacing,
                 context.getResources().getDimensionPixelOffset(DF_TICK_SPACING_RES));
+
         //
         afterInit();
         //
@@ -150,7 +151,7 @@ private void addDrawableTick(Context context, int position) {
     }
 
     private void updateTicksClickParameters(View tick, int position) {
-        if (clickable) {
+        if (isClickable()) {
             tick.setTag(R.id.prb_tick_tag_id, position);
             tick.setOnClickListener(mTickClickedListener);
         } else {
@@ -219,7 +220,6 @@ private interface TicksIterator {
     public Parcelable onSaveInstanceState() {
         SavedState savedState = new SavedState(super.onSaveInstanceState());
         savedState.rating = rating;
-        savedState.clickable = clickable;
 
         return savedState;
     }
@@ -240,7 +240,6 @@ public void onRestoreInstanceState(Parcelable state) {
     static class SavedState extends BaseSavedState {
 
         int rating;
-        boolean clickable;
 
         SavedState(Parcelable superState) {
             super(superState);
@@ -249,14 +248,12 @@ static class SavedState extends BaseSavedState {
         private SavedState(Parcel in) {
             super(in);
             this.rating = in.readInt();
-            this.clickable = in.readByte() == 1;
         }
 
         @Override
         public void writeToParcel(Parcel out, int flags) {
             super.writeToParcel(out, flags);
             out.writeInt(this.rating);
-            out.writeByte((byte) (this.clickable ? 1 : 0));
         }
 
         public static final Parcelable.Creator<SavedState> CREATOR = new Parcelable.Creator<SavedState>() {
@@ -270,23 +267,38 @@ public SavedState[] newArray(int size) {
         };
     }
 
+    @Override
+    public boolean dispatchTouchEvent(MotionEvent event) {
+        if (!isClickable()) {
+            return super.dispatchTouchEvent(event);
+        }
+
+        if (event.getAction() == MotionEvent.ACTION_MOVE) {
+            int containerWidth = getWidth();
+            float x = event.getX();
+            int oneTickWidth = containerWidth / totalTicks;
+            int r = (int)(Math.ceil(x / oneTickWidth));
+            if (getRating() != r) {
+                setRating(r);
+                return true;
+            }
+        }
+        return super.dispatchTouchEvent(event);
+    }
+
     ///////////////////////////////////////////////////////////////////////////
     // Essential public methods
     ///////////////////////////////////////////////////////////////////////////
 
-    public boolean isClickable() {
-        return clickable;
-    }
-
     /**
      * Nifty sugar method to just toggle clickable to opposite state.
      */
     public void toggleClickable() {
-        setClickable(!clickable);
+        setClickable(!isClickable());
     }
 
     public void setClickable(boolean clickable) {
-        this.clickable = clickable;
+        super.setClickable(clickable);
         iterateTicks(new TicksIterator() {
             @Override
             public void onTick(View tick, int position) {
@@ -336,6 +348,8 @@ public int getRating() {
      */
     public void setRating(int rating) {
         if (rating  > this.totalTicks) rating = totalTicks;
+        if (rating < this.minRating) rating = minRating;
+
         this.rating = rating;
         lastSelectedTickIndex = rating - 1;
         redrawTicks();
@@ -349,4 +363,20 @@ public void setSymbolicTick(String tick) {
     public String getSymbolicTick() {
         return this.symbolicTick;
     }
+
+    public void setTickNormalDrawable(Drawable tickDrawable) {
+        this.tickNormalDrawable = tickDrawable;
+    }
+
+    public void setTickSelectedDrawable(Drawable tickDrawable) {
+        this.tickSelectedDrawable = tickDrawable;
+    }
+
+    public Drawable getTickNormalDrawable() {
+        return tickNormalDrawable;
+    }
+
+    public Drawable setTickSelectedDrawable() {
+        return tickSelectedDrawable;
+    }
 }

From 43aab12d5a1ee67f89e68e5a5a26e07035493507 Mon Sep 17 00:00:00 2001
From: "jihoon.park" <jihoon.park@rgpkorea.co.kr>
Date: Wed, 6 Sep 2017 12:31:04 +0900
Subject: [PATCH 2/7] libary group name changed.

---
 library/build.gradle | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/library/build.gradle b/library/build.gradle
index 1062418..96c123d 100644
--- a/library/build.gradle
+++ b/library/build.gradle
@@ -1,6 +1,6 @@
 apply plugin: 'com.android.library'
 
-group = "io.techery"
+group = "com.github.brannpark"
 
 android {
 

From ea63c27cbaa50277da014368760a2248343fbd16 Mon Sep 17 00:00:00 2001
From: "jihoon.park" <jihoon.park@rgpkorea.co.kr>
Date: Wed, 6 Sep 2017 12:42:25 +0900
Subject: [PATCH 3/7] update README

---
 README.md        | 32 ++++++++++++++++++++++++++++----
 app/build.gradle |  9 ++++++++-
 2 files changed, 36 insertions(+), 5 deletions(-)

diff --git a/README.md b/README.md
index ecc7fac..ff839a8 100644
--- a/README.md
+++ b/README.md
@@ -12,6 +12,7 @@ Whatever you need to display some rating or pricing category - just use ProperRa
         android:textSize="22sp"
         android:textStyle="bold"
         app:prb_defaultRating="4"
+		app:prb_minRating="1"
         app:prb_symbolicTick="$"
         app:prb_symbolicTickNormalColor="@android:color/darker_gray"
         app:prb_symbolicTickSelectedColor="@android:color/holo_green_dark"
@@ -44,7 +45,7 @@ Library's minSdkVersion is set to 14.
 
 We use jitpack, so you can obtain made-up library right from our github sources in your module's `build.gradle` file:
 
-`compile 'com.github.techery:properratingbar:{version_name}'`
+`compile 'com.github.branpark:ProperRatingBar:0.0.6'`
 
 Also you need to add jitpack as repository in the same file:
 ```groovy
@@ -59,7 +60,7 @@ So far we only support customising via xml layout.
 Here is the list of applicable attributes:
 + ``prb_totalTicks``: total number of ticks to show. Default is '5'
 + ``prb_defaultRating``: use this to set rating from xml. Default is '3'
-+ ``prb_clickable``: if set to 'true' - use will be able to change rating by clicking. Default is 'false'
++ ``prb_minRating`` : user this to set minimum rating. Default is '0'
 
 + ``prb_symbolicTick``: symbol to be used as a tick. Default is '$'
 + ``android:textSize``: text size of symbolic tick. Default is '15sp'
@@ -74,8 +75,6 @@ Here is the list of applicable attributes:
 Also there's a number of methods to operate on ProperRatingBar programmatically:
 ```java
 
-public boolean isClickable();
-
 /**
  * Nifty sugar method to just toggle clickable to opposite state.
  */
@@ -112,6 +111,31 @@ public int getRating();
 * @param rating new rating value
 */
 public void setRating(int rating);
+
+/**
+* Set normal tick drawable
+* @param tickDrawable normal tick drawable
+*/
+public void setTickNormalDrawable(Drawable tickDrawable);
+
+/**
+* Set selected tick drawable
+* @param tickDrawable selected tick drawable
+*/
+public void setTickSelectedDrawable(Drawable tickDrawable);
+
+/**
+* Get normal tick drawable
+* @retrun normal tick drawable
+*/
+public Drawable getTickNormalDrawable();
+
+/**
+* Get selected tick drawable
+* @retrun selected tick drawable
+*/
+public Drawable setTickSelectedDrawable();
+
 ```
 
 ## Tests
diff --git a/app/build.gradle b/app/build.gradle
index 03d2017..c353da1 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -1,5 +1,11 @@
 apply plugin: 'com.android.application'
 
+allprojects {
+    repositories {
+        maven { url 'https://jitpack.io' }
+    }
+}
+
 android {
     compileSdkVersion 23
     buildToolsVersion '25.0.0'
@@ -25,5 +31,6 @@ dependencies {
     compile 'com.android.support:appcompat-v7:23.4.0'
     compile 'com.android.support:design:23.4.0'
     compile 'com.jakewharton:butterknife:7.0.1'
-    compile project(':library')
+    compile 'com.github.brannpark:ProperRatingBar:0.0.6'
+    //compile project(':library')
 }

From 9e1a48cf6b7515f281ccd5bf6e47a5293ff746ad Mon Sep 17 00:00:00 2001
From: "jihoon.park" <jihoon.park@rgpkorea.co.kr>
Date: Wed, 6 Sep 2017 14:32:01 +0900
Subject: [PATCH 4/7] Add tick animation feature. refactored codes of
 RatingListener.

---
 app/build.gradle                              |   3 +-
 .../main/res/anim/animation_scale_updown.xml  |   8 ++
 app/src/main/res/layout/content_main.xml      |   1 +
 library/res/values/attrs.xml                  |   3 +
 .../properratingbar/ProperRatingBar.java      | 108 ++++++++++--------
 5 files changed, 75 insertions(+), 48 deletions(-)
 create mode 100644 app/src/main/res/anim/animation_scale_updown.xml

diff --git a/app/build.gradle b/app/build.gradle
index c353da1..e43f4fb 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -31,6 +31,5 @@ dependencies {
     compile 'com.android.support:appcompat-v7:23.4.0'
     compile 'com.android.support:design:23.4.0'
     compile 'com.jakewharton:butterknife:7.0.1'
-    compile 'com.github.brannpark:ProperRatingBar:0.0.6'
-    //compile project(':library')
+    compile project(':library')
 }
diff --git a/app/src/main/res/anim/animation_scale_updown.xml b/app/src/main/res/anim/animation_scale_updown.xml
new file mode 100644
index 0000000..aed7dd7
--- /dev/null
+++ b/app/src/main/res/anim/animation_scale_updown.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="utf-8"?>
+<set xmlns:android="http://schemas.android.com/apk/res/android"
+    android:duration="300">
+    <scale
+        android:fromXScale="1.5" android:toXScale="1.0"
+        android:fromYScale="1.5" android:toYScale="1.0"
+        android:pivotX="50%" android:pivotY="50%" />
+</set>
\ No newline at end of file
diff --git a/app/src/main/res/layout/content_main.xml b/app/src/main/res/layout/content_main.xml
index cf74c49..b03ee6d 100644
--- a/app/src/main/res/layout/content_main.xml
+++ b/app/src/main/res/layout/content_main.xml
@@ -59,6 +59,7 @@
         android:layout_gravity="center_horizontal"
         android:layout_margin="@dimen/sample_default_margin"
         android:clickable="true"
+        app:prb_tickAnimation="@anim/animation_scale_updown"
         app:prb_defaultRating="4"
         app:prb_tickNormalDrawable="@drawable/ic_star_normal"
         app:prb_tickSelectedDrawable="@drawable/ic_star_selected"
diff --git a/library/res/values/attrs.xml b/library/res/values/attrs.xml
index baff9e6..1bbc9c4 100644
--- a/library/res/values/attrs.xml
+++ b/library/res/values/attrs.xml
@@ -39,6 +39,9 @@
         <!-- Symbol to be used as a tick. Default is '$' -->
         <attr name="prb_symbolicTick" format="string" />
 
+        <!-- Tick animation to use. No default value. -->
+        <attr name="prb_tickAnimation" format="reference" />
+
         <!-- Text size of symbolic tick. Default is '15sp' -->
         <attr name="android:textSize" />
 
diff --git a/library/src/io/techery/properratingbar/ProperRatingBar.java b/library/src/io/techery/properratingbar/ProperRatingBar.java
index 3f9815f..e77aa27 100644
--- a/library/src/io/techery/properratingbar/ProperRatingBar.java
+++ b/library/src/io/techery/properratingbar/ProperRatingBar.java
@@ -11,6 +11,8 @@
 import android.util.TypedValue;
 import android.view.MotionEvent;
 import android.view.View;
+import android.view.animation.Animation;
+import android.view.animation.AnimationUtils;
 import android.widget.ImageView;
 import android.widget.LinearLayout;
 import android.widget.TextView;
@@ -66,10 +68,11 @@ public class ProperRatingBar extends LinearLayout {
     private Drawable tickSelectedDrawable;
     private int tickSpacing;
 
-    private boolean useSymbolicTick = false;
+    private boolean useSymbolicTick;
     private int rating;
     private int minRating;
-    private RatingListener listener = null;
+    private int animResId;
+    private RatingListener listener;
 
     public ProperRatingBar(Context context, AttributeSet attrs) {
         super(context, attrs);
@@ -99,6 +102,8 @@ private void init(Context context, AttributeSet attrs) {
         tickSpacing = a.getDimensionPixelOffset(R.styleable.ProperRatingBar_prb_tickSpacing,
                 context.getResources().getDimensionPixelOffset(DF_TICK_SPACING_RES));
 
+        animResId = a.getResourceId(R.styleable.ProperRatingBar_prb_tickAnimation, 0);
+
         //
         afterInit();
         //
@@ -119,56 +124,35 @@ private void afterInit() {
     private void addTicks(Context context) {
         this.removeAllViews();
         for (int i = 0; i < totalTicks; i++) {
-            addTick(context, i);
+            addTick(context);
         }
         redrawTicks();
     }
 
-    private void addTick(Context context, int position) {
+    private void addTick(Context context) {
         if (useSymbolicTick) {
-            addSymbolicTick(context, position);
+            addSymbolicTick(context);
         } else {
-            addDrawableTick(context, position);
+            addDrawableTick(context);
         }
     }
 
-    private void addSymbolicTick(Context context, int position) {
+    private void addSymbolicTick(Context context) {
         TextView tv = new TextView(context);
         tv.setText(symbolicTick);
         tv.setTextSize(TypedValue.COMPLEX_UNIT_PX, customTextSize);
         if (customTextStyle != 0) {
             tv.setTypeface(Typeface.DEFAULT, customTextStyle);
         }
-        updateTicksClickParameters(tv, position);
         this.addView(tv);
     }
 
-    private void addDrawableTick(Context context, int position) {
+    private void addDrawableTick(Context context) {
         ImageView iv = new ImageView(context);
         iv.setPadding(tickSpacing, tickSpacing, tickSpacing, tickSpacing);
-        updateTicksClickParameters(iv, position);
         this.addView(iv);
     }
 
-    private void updateTicksClickParameters(View tick, int position) {
-        if (isClickable()) {
-            tick.setTag(R.id.prb_tick_tag_id, position);
-            tick.setOnClickListener(mTickClickedListener);
-        } else {
-            tick.setOnClickListener(null);
-        }
-    }
-
-    private View.OnClickListener mTickClickedListener = new OnClickListener() {
-        @Override
-        public void onClick(View v) {
-            lastSelectedTickIndex = (int) v.getTag(R.id.prb_tick_tag_id);
-            rating = lastSelectedTickIndex + 1;
-            redrawTicks();
-            if (listener != null) listener.onRatePicked(ProperRatingBar.this);
-        }
-    };
-
     private void redrawTicks() {
         iterateTicks(new TicksIterator() {
             @Override
@@ -273,12 +257,13 @@ public boolean dispatchTouchEvent(MotionEvent event) {
             return super.dispatchTouchEvent(event);
         }
 
-        if (event.getAction() == MotionEvent.ACTION_MOVE) {
+        int action = event.getAction();
+        if (action == MotionEvent.ACTION_MOVE || action == MotionEvent.ACTION_UP) {
             int containerWidth = getWidth();
             float x = event.getX();
             int oneTickWidth = containerWidth / totalTicks;
             int r = (int)(Math.ceil(x / oneTickWidth));
-            if (getRating() != r) {
+            if (rating != r) {
                 setRating(r);
                 return true;
             }
@@ -286,6 +271,25 @@ public boolean dispatchTouchEvent(MotionEvent event) {
         return super.dispatchTouchEvent(event);
     }
 
+    private Animation loadAnimation() {
+        if (animResId > 0) {
+            return AnimationUtils.loadAnimation(getContext(), animResId);
+        }
+        return null;
+    }
+
+    private void animateLastSelectedTick() {
+        Animation anim = loadAnimation();
+        if (anim == null) {
+            return ;
+        }
+        View tickView = getChildAt(lastSelectedTickIndex);
+        if (tickView != null) {
+            tickView.clearAnimation();
+            tickView.startAnimation(anim);
+        }
+    }
+
     ///////////////////////////////////////////////////////////////////////////
     // Essential public methods
     ///////////////////////////////////////////////////////////////////////////
@@ -297,14 +301,16 @@ public void toggleClickable() {
         setClickable(!isClickable());
     }
 
-    public void setClickable(boolean clickable) {
-        super.setClickable(clickable);
-        iterateTicks(new TicksIterator() {
-            @Override
-            public void onTick(View tick, int position) {
-                updateTicksClickParameters(tick, position);
-            }
-        });
+    /**
+     * Animation resource id to apply to the tick view.
+     * @param animResId animation resource id
+     */
+    public void setTickAnimationResId(int animResId) {
+        this.animResId = animResId;
+    }
+
+    public int getTickAnimationResId() {
+        return animResId;
     }
 
     /**
@@ -344,15 +350,25 @@ public int getRating() {
 
     /**
      * Set the rating to show
-     * @param rating new rating value
+     * @param value new rating value
      */
-    public void setRating(int rating) {
-        if (rating  > this.totalTicks) rating = totalTicks;
-        if (rating < this.minRating) rating = minRating;
+    public void setRating(int value) {
+        int newRating = value;
+        if (newRating  > this.totalTicks) {
+            newRating = totalTicks;
+        } else if (newRating < this.minRating) {
+            newRating = minRating;
+        }
 
-        this.rating = rating;
-        lastSelectedTickIndex = rating - 1;
-        redrawTicks();
+        if (this.rating != newRating) {
+            this.rating = newRating;
+            lastSelectedTickIndex = newRating - 1;
+            if (listener != null) {
+                listener.onRatePicked(this);
+            }
+            redrawTicks();
+            animateLastSelectedTick();
+        }
     }
 
     public void setSymbolicTick(String tick) {

From 7a710421bae51d4ce1f9b0a03321422050e4bf5f Mon Sep 17 00:00:00 2001
From: "jihoon.park" <jihoon.park@rgpkorea.co.kr>
Date: Wed, 6 Sep 2017 14:34:32 +0900
Subject: [PATCH 5/7] redraw ticks when drawable changed.

---
 library/src/io/techery/properratingbar/ProperRatingBar.java | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/library/src/io/techery/properratingbar/ProperRatingBar.java b/library/src/io/techery/properratingbar/ProperRatingBar.java
index e77aa27..b5421b5 100644
--- a/library/src/io/techery/properratingbar/ProperRatingBar.java
+++ b/library/src/io/techery/properratingbar/ProperRatingBar.java
@@ -382,10 +382,12 @@ public String getSymbolicTick() {
 
     public void setTickNormalDrawable(Drawable tickDrawable) {
         this.tickNormalDrawable = tickDrawable;
+        redrawTicks();
     }
 
     public void setTickSelectedDrawable(Drawable tickDrawable) {
         this.tickSelectedDrawable = tickDrawable;
+        redrawTicks();
     }
 
     public Drawable getTickNormalDrawable() {

From a1d2c4c813e251d319b1e89e872dd3c4e731b44a Mon Sep 17 00:00:00 2001
From: "jihoon.park" <jihoon.park@rgpkorea.co.kr>
Date: Wed, 6 Sep 2017 14:40:08 +0900
Subject: [PATCH 6/7] update README

---
 README.md                                            | 12 +++++++++++-
 app/src/main/res/layout/content_main.xml             |  3 ++-
 .../io/techery/properratingbar/ProperRatingBar.java  |  2 +-
 3 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index ff839a8..87d4a90 100644
--- a/README.md
+++ b/README.md
@@ -17,6 +17,7 @@ Whatever you need to display some rating or pricing category - just use ProperRa
         app:prb_symbolicTickNormalColor="@android:color/darker_gray"
         app:prb_symbolicTickSelectedColor="@android:color/holo_green_dark"
         app:prb_totalTicks="5"
+		app:prb_tickAnimation="@anroid:anim/fade_in"
         />
 ```
 
@@ -60,7 +61,7 @@ So far we only support customising via xml layout.
 Here is the list of applicable attributes:
 + ``prb_totalTicks``: total number of ticks to show. Default is '5'
 + ``prb_defaultRating``: use this to set rating from xml. Default is '3'
-+ ``prb_minRating`` : user this to set minimum rating. Default is '0'
++ ``prb_minRating`` : use this to set minimum rating. Default is '0'
 
 + ``prb_symbolicTick``: symbol to be used as a tick. Default is '$'
 + ``android:textSize``: text size of symbolic tick. Default is '15sp'
@@ -71,6 +72,7 @@ Here is the list of applicable attributes:
 + ``prb_tickNormalDrawable``: drawable resource to use as a tick that is not selected (not rated). No default value
 + ``prb_tickSelectedDrawable``: drawable resource to use as a tick that is selected (rated). No default value
 + ``prb_tickSpacing``: margin to be applied to tick drawables. Only applies to drawable-type ticks. Default is '1dp' (gray)
++ ``prb_tickAnimation``: Animation to be applied to the tick view. No default value.
 
 Also there's a number of methods to operate on ProperRatingBar programmatically:
 ```java
@@ -136,6 +138,14 @@ public Drawable getTickNormalDrawable();
 */
 public Drawable setTickSelectedDrawable();
 
+/**
+* Animation resource id to be applied to the tick view.
+* @param animResId animation resource id
+*/
+public void setTickAnimationResId(int animResId);
+
+public int getTickAnimationResId();
+
 ```
 
 ## Tests
diff --git a/app/src/main/res/layout/content_main.xml b/app/src/main/res/layout/content_main.xml
index b03ee6d..7d21e77 100644
--- a/app/src/main/res/layout/content_main.xml
+++ b/app/src/main/res/layout/content_main.xml
@@ -52,6 +52,7 @@
         android:textSize="@dimen/sample_caption_text_size"
         />
 
+    <!-- app:prb_tickAnimation="@anim/animation_scale_updown" -->
     <io.techery.properratingbar.ProperRatingBar
         android:id="@+id/lowerRatingBar"
         android:layout_width="wrap_content"
@@ -59,7 +60,7 @@
         android:layout_gravity="center_horizontal"
         android:layout_margin="@dimen/sample_default_margin"
         android:clickable="true"
-        app:prb_tickAnimation="@anim/animation_scale_updown"
+        app:prb_tickAnimation="@android:anim/fade_in"
         app:prb_defaultRating="4"
         app:prb_tickNormalDrawable="@drawable/ic_star_normal"
         app:prb_tickSelectedDrawable="@drawable/ic_star_selected"
diff --git a/library/src/io/techery/properratingbar/ProperRatingBar.java b/library/src/io/techery/properratingbar/ProperRatingBar.java
index b5421b5..2a5b7ea 100644
--- a/library/src/io/techery/properratingbar/ProperRatingBar.java
+++ b/library/src/io/techery/properratingbar/ProperRatingBar.java
@@ -302,7 +302,7 @@ public void toggleClickable() {
     }
 
     /**
-     * Animation resource id to apply to the tick view.
+     * Animation resource id to be applied to the tick view.
      * @param animResId animation resource id
      */
     public void setTickAnimationResId(int animResId) {

From ea26aef68afcc41254ec5980e27f78d7cc144cdd Mon Sep 17 00:00:00 2001
From: "jihoon.park" <jihoon.park@rgpkorea.co.kr>
Date: Wed, 6 Sep 2017 15:02:33 +0900
Subject: [PATCH 7/7] remove left/right padding of ProperRatingBar when
 calcuates touch rating value

---
 app/src/main/res/layout/content_main.xml                    | 5 +++--
 library/src/io/techery/properratingbar/ProperRatingBar.java | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/app/src/main/res/layout/content_main.xml b/app/src/main/res/layout/content_main.xml
index 7d21e77..cf3aa1a 100644
--- a/app/src/main/res/layout/content_main.xml
+++ b/app/src/main/res/layout/content_main.xml
@@ -52,15 +52,16 @@
         android:textSize="@dimen/sample_caption_text_size"
         />
 
-    <!-- app:prb_tickAnimation="@anim/animation_scale_updown" -->
     <io.techery.properratingbar.ProperRatingBar
         android:id="@+id/lowerRatingBar"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_gravity="center_horizontal"
         android:layout_margin="@dimen/sample_default_margin"
+        android:paddingLeft="40dp"
+        android:paddingRight="40dp"
         android:clickable="true"
-        app:prb_tickAnimation="@android:anim/fade_in"
+        app:prb_tickAnimation="@anim/animation_scale_updown"
         app:prb_defaultRating="4"
         app:prb_tickNormalDrawable="@drawable/ic_star_normal"
         app:prb_tickSelectedDrawable="@drawable/ic_star_selected"
diff --git a/library/src/io/techery/properratingbar/ProperRatingBar.java b/library/src/io/techery/properratingbar/ProperRatingBar.java
index 2a5b7ea..c66486b 100644
--- a/library/src/io/techery/properratingbar/ProperRatingBar.java
+++ b/library/src/io/techery/properratingbar/ProperRatingBar.java
@@ -259,8 +259,8 @@ public boolean dispatchTouchEvent(MotionEvent event) {
 
         int action = event.getAction();
         if (action == MotionEvent.ACTION_MOVE || action == MotionEvent.ACTION_UP) {
-            int containerWidth = getWidth();
-            float x = event.getX();
+            int containerWidth = getWidth() - getPaddingLeft() - getPaddingRight();
+            float x = event.getX() - getPaddingLeft();
             int oneTickWidth = containerWidth / totalTicks;
             int r = (int)(Math.ceil(x / oneTickWidth));
             if (rating != r) {