Use formatted stopwatch attributes instead of calling format_* helpers (#4417)

Same thing, but much harder to forget. `Stopwatch` offers the properly
formatted versions of timestamps and duration.

Author: happz

tmt/steps/execute/__init__.py

@@ -46,8 +46,6 @@
     ShellScript,
     Stopwatch,
     configure_bool_constant,
-    format_duration,
-    format_timestamp,
 )
 
 if TYPE_CHECKING:
@@ -389,7 +387,7 @@ def _reset_process(
                     tmt.utils.signals.remove_callback(self.on_interrupt_callback_token)
 
         with Stopwatch() as timer:
-            self.start_time = format_timestamp(timer.start_time)
+            self.start_time = timer.start_time_formatted
 
             try:
                 output = self.guest.execute(
@@ -423,8 +421,8 @@ def _reset_process(
                 elif tmt.utils.ProcessExitCodes.is_pidfile(self.return_code):
                     self.logger.warning('Test failed to manage its pidfile.')
 
-        self.end_time = format_timestamp(timer.end_time)
-        self.real_duration = format_duration(timer.duration)
+        self.end_time = timer.end_time_formatted
+        self.real_duration = timer.duration_formatted
 
         return output
 
@@ -919,9 +917,9 @@ def _run_checks_for_test(
             for result in check_results:
                 result.event = event
 
-                result.start_time = format_timestamp(timer.start_time)
-                result.end_time = format_timestamp(timer.end_time)
-                result.duration = format_duration(timer.duration)
+                result.start_time = timer.start_time_formatted
+                result.end_time = timer.end_time_formatted
+                result.duration = timer.duration_formatted
 
             results += check_results
 

tmt/utils/__init__.py

@@ -6101,6 +6101,10 @@ def start_time_formatted(self) -> str:
     def end_time_formatted(self) -> str:
         return format_timestamp(self.end_time)
 
+    @property
+    def duration_formatted(self) -> str:
+        return format_duration(self.duration)
+
     @classmethod
     def measure(
         cls, fn: Callable[P, T], *args: P.args, **kwargs: P.kwargs