rpc_api.py -> _build_subrequests needs more code

[Nostrademous]

For AttackGym - we need to be able to send repeated BattleAction objects/classes. Currently rpc_api.py only handles "repeated" base-types (i.e., ints, longs, strings) by accepting a "list" and iterating over it and then appending to the necessary attribute. Need improvement to support AttackGym protobuf.

message AttackGymMessage {
    string gym_id = 1;
    string battle_id = 2;
    repeated .POGOProtos.Data.Battle.BattleAction attack_actions = 3;
    .POGOProtos.Data.Battle.BattleAction last_retrieved_actions = 4;
    double player_latitude = 5;
    double player_longitude = 6;
}

Something like: NOTE - COMPLETELY UNTESTED CODE (also, I'm using old protobuf file structure)

                for (key, value) in entry_content.items():
                    if isinstance(value, list):
                        #self.log.error('Found list: %s - trying as repeated', key)
                        for i in value:
                            #self.log.error('Value is %s' % (type(i)))
                            if isinstance(i, RpcSub.BattleAction):
                                self.log.error('RpcSub.BattleAction Class')
                                subsub_ext = get_class('pgoapi.protos.RpcSub_pb2.BattleAction')()
                                try:
                                    setattr(subsub_ext, 'Type', i.Type)
                                    setattr(subsub_ext, 'action_start_ms', i.action_start_ms)
                                    setattr(subsub_ext, 'duration_ms', i.duration_ms)
                                    setattr(subsub_ext, 'target_index', i.target_index) 
                                    r = getattr(subrequest_extension, key)
                                    r.append(subsub_ext)
                                except Exception as e:
                                    self.log.warning('Argument %s with value %s unknown inside %s (Exception: %s)', key, str(value), proto_name, str(e))

                            else:
                                try:
                                    r = getattr(subrequest_extension, key)
                                    r.append(i)
                                except Exception as e:
                                    self.log.warning('Arguement %s with value %s unknown inside %s (Exception %s)', key, i, proto_name, str(e))

There are probably much sexier python methods to do this

[Nihisil]

I would like to have it implemented :)

[neotomek]

@Nostrademous can u past part of code where u call AttackGymMessage ?

[Nostrademous]

@Nihisil @tejado Enjoy.

Let me know when Unknown6 is resolved and I will work on fixing any of the broken code... couldn't test it without solving the issue mentioned in this "issue" (which I can fix probably with code I suggested although @tejado would do it more eloquently probably) and then the Unknown6 issue happened.

@tejado - I moved the "decode_raw()" function to pgoapi/utilities.py so that I can invoke it when trouble shooting a specific API call by passing a debugflag through the "call()". Perhaps it's generally a good idea rather then keeping it in rpc_api.py exclusively.

    def investigateGym(self, fort, dist, direction):
        sGymColor = renum.TeamColor.DESCRIPTOR.values[fort.owned_by_team].name

        # get gym details
        gym_proto = self.getGymDetails(fort)
        if not gym_proto: return 0, 0, 0

        ##############################################
        # gather necessary details to start a battle #
        ##############################################

        # check if gym in battle
        if fort.is_in_battle:
            log.info('Gym currently in battle')
            return 0, 0, 0

        # check if gym is neutral/unowned - if so deploy to it
        if fort.owned_by_team == 0: # Neutral
            log.info('Gym @ [%f, %f] is NEUTRAL, %d meters %s' % (fort.latitude, fort.longitude, dist, direction))
            if dist < 32.0:
                self.deployPokemonToGym(fort.id)
                return 0, 0, 0
            else:
                return 1, fort.latitude, fort.longitude

        # save a boolean checking if we are on the same team
        sameTeam = self.my_team == fort.owned_by_team

        # find out who is defending
        defending_pokemon = []
        for defender in gym_proto.gym_state.memberships:
            defending_pokemon.append(defender.pokemon_data.id)

        # check gym prestige & level and membership
        gymLevel = self.getGymLevel(fort.gym_points)
        log.info('%s Gym @ [%f, %f] %d meters %s :: Prestige: %d, Level: %d, Pokemon: %d' % (sGymColor, fort.latitude, fort.longitude, dist, direction, fort.gym_points, gymLevel, len(defending_pokemon)))

        if sameTeam and gymLevel > len(defending_pokemon):
            log.info('We can deploy to gym @ [%f, %f] :: %d meters %s' % (fort.latitude, fort.longitude, dist, direction))
            if dist < 32.0:
                self.deployPokemonToGym(fort.id)
                return 0, 0, 0
            elif fort.id in self.gyms_with_my_pokemon:
                return 0, 0, 0
            else:
                return 1, fort.latitude, fort.longitude

        if not sameTeam:
            if dist < 32.0:
                self.battleGym(fort, sameTeam, defending_pokemon)
            else:
                log.info('Heading for gym to fight...')
                return 1, fort.latitude, fort.longitude
        return 0, 0, 0

    def battleGym(self, fort, sameTeam, defenders):
        # determine who we will attack with
        num = 6
        if sameTeam: num = 1
        my_attackers = self.pickAttackers(num) # this will be a list []

        # start the battle
        log.info('GymID: %s' % fort.id)
        log.info('Attacker list: %s' % str(my_attackers))
        log.info('Defender: %d' % defenders[0])
        self.api.start_gym_battle(gym_id=fort.id, attacking_pokemon_ids=my_attackers, defending_pokemon_id=defenders[0], player_latitude=self.p_lat, player_longitude=self.p_lng)

        start_reply = self.api.call(False, True)
        start_payload = self.getPayload(start_reply)
        if start_payload:
            start_resp = rsub.StartGymBattleResponse()
            start_resp.ParseFromString(start_payload)
            log.info(start_resp)

            if start_resp.result == 1: # SUCCESS
                tgt_indx = self.sendBlankAction(fort.id, start_resp.battle_id)
                if len(tgt_indx) > 0:
                    log.info('Starting Real Battle...')
                    battleState = start_resp.battle_log.state
                    serverTime = start_resp.battle_log.server_ms
                    while not self.battleConcluded(battleState):
                        log.info('Attacking...')
                        suc, battleState, serverTime, tgt_indx = self.sendAttack(fort.id, start_resp.battle_id, serverTime, tgt_indx[0], times=5)
                        if not suc:
                            log.error('something went wrong in our battle')
                            break
                    log.info('Battle Result: %d', battleState)
                    return 0
                else:
                    return 0
            else:
                return 0
        else:
            log.error('startGymBattle() request failed to get payload')
            log.error('Decode raw over protoc (protoc has to be in your PATH):\n\r%s', decode_raw(start_reply.content))
            return 0

    def sendAttack(self, gym_id, battle_id, serverTime, tgtIndx, times=5):
        actions = []
        for i in range(0, times):
            battleAction = rsub.BattleAction(Type=1, action_start_ms=(serverTime + 100*i), duration_ms=500, target_index=tgtIndx)
            actions.append(battleAction)
        self.api.attack_gym(gym_id=gym_id, battle_id=battle_id, attack_actions=actions, player_latitude=self.p_lat, player_longitude=self.p_lng)
        attack = self.api.call(False)
        attack_pay = self.getPayload(attack)
        if attack_pay:
            attack_resp = rsub.AttackGymResponse()
            attack_resp.ParseFromString(attack_pay)
            log.info(attack_resp)
            if attack_resp.result == 1: # SUCCESS
                target_index = []
                for action in attack_resp.battle_log.battle_actions:
                    log.info('Target Index: %d' % (action.target_index))
                    if action.target_index not in target_index: target_index.append(action.target_index)
                time.sleep(100*times)
                return 1, attack_resp.battle_log.state, attack_resp.battle_log.server_ms, target_index
            return 0, 0, 0, []
        else:
            log.error('sendAttack() failed to get payload')
            log.error('Decode raw over protoc (protoc has to be in your PATH):\n\r%s', decode_raw(attack.content))
        return 0, 0, 0, []


    def sendBlankAction(self, gym_id, battle_id):
        self.api.attack_gym(gym_id=gym_id, battle_id=battle_id, player_latitude=self.p_lat, player_longitude=self.p_lng)
        blank = self.api.call(False)
        blank_pay = self.getPayload(blank)
        if blank_pay:
            blank_resp = rsub.AttackGymResponse()
            blank_resp.ParseFromString(blank_pay)
            log.info(blank_resp)
            if blank_resp.result == 1: # SUCCESS
                target_index = []
                for action in blank_resp.battle_log.battle_actions:
                    log.info('Target Index: %d' % (action.target_index))
                    if action.target_index not in target_index: target_index.append(action.target_index)
                    return target_index
            return []
        else:
            log.error('sendBlankAction() failed to obtain response payload')
            return []


    def battleConcluded(self, battleState):
        if battleState in [2,3,4]: # 2 == VICTORY, 3 == DEFEATED, 4 == TIMED_OUT
            return True
        return False

[dnsBlah]

wow that looks awesome and really promissing
how'd you did this? Already before the last update now everything is down? Or... You alreay have it all working again? ;-)

Or is it untested yet?

Looks awesome! Nice work

[Nihisil]

@Nostrademous Thank you

[elliottcarlson]

Looks like this is resolved and can be closed.

[Nostrademous]

@elliottcarlson how is this resolved? I posted theoretical code that I cannot test currently until I get the signatures working. Additionally, even if by some miracle the code I posted is 100% accurate it still needs to be accepted.

[elliottcarlson]

You are correct, I lost track of the original ticket. Sorry about that.

On Aug 8, 2016 8:24 AM, "Nostrademous" notifications@github.com wrote:

@elliottcarlson https://github.com/elliottcarlson how is this resolved?
I posted theoretical code that I cannot test currently until I get the
signatures working. Additionally, even if by some miracle the code I posted
is 100% accurate it still needs to be accepted.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#175 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AANYSNp5YAzPXsQBsPr3v81FUO1TR0vCks5qdx_xgaJpZM4JcDux
.

[Nostrademous]

Able to commence testing... however, of interest, I think I figured out a better way to deal with repeated request message parameters than what I suggested. We'll test soon.

[Nihisil]

@Nostrademous thank you. I'm looking forward to see this better way. I wasn't able to make it work (I tried your suggestions and other different things)

[Nostrademous]

@Nihisil so protobufs by design have an "add()" for any field labelled as repeated. That's my better way for dealing with lists that I want to try. At work currently so can't test for a bit.

[Nihisil]

@Nostrademous yeah, I tried .add() and .extend([item]) but it didn't work for me, on these requests server return "responses": {"ATTACK_GYM": {"result": 2}}.

This is first time when I'm working with protobuf, so there is a big chance that I didn't get something essential.

I hope you will handle it in your free time :) good luck!

[Nostrademous]

Getting ERROR_INVALID_ATTACK_ACTION reponses on my attacks... so glue is working, just need to fix the values I'm passing.

[Nihisil]

@Nostrademous any news here? Can you, please, share your fix? So, I will try to make a correct attack action.

[Nostrademous]

@Nihisil
#214