Skip to content

Commit ef80dc4

Browse files
🐛 Fix the CI job validating the codeowners (#2641)
* 🐛 Fix the CI job validating the codeowners
1 parent d86dfac commit ef80dc4

File tree

2 files changed

+31
-13
lines changed

2 files changed

+31
-13
lines changed

.github/workflows/ci_test.yml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -84,19 +84,6 @@ jobs:
8484
steps:
8585
- uses: actions/checkout@v2
8686
- run: bash tools/run_cpu_tests.sh
87-
valid-codeowners:
88-
name: Check that the CODEOWNERS is valid
89-
runs-on: ubuntu-latest
90-
steps:
91-
- uses: actions/checkout@v2
92-
- uses: actions/setup-python@v1
93-
with:
94-
python-version: 3.7
95-
- run: pip install pygithub click
96-
- name: Check that the CODEOWNERS is valid
97-
env:
98-
BOT_TOKEN: ${{ secrets.BOT_TOKEN }}
99-
run: python .github/workflows/notify_codeowners.py
10087
nbfmt:
10188
name: Notebook format
10289
runs-on: ubuntu-latest
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
name: Validate codeowners
2+
3+
on:
4+
push:
5+
branches:
6+
- master
7+
- r*
8+
9+
# pull_request_target:
10+
# branches:
11+
# - master
12+
# - r*
13+
# Enable pull_request_target when notify_codeowners.py can validate the codeowners file
14+
# of the commit that triggered the workflow, not the commit the workflow is runnng on.
15+
# Otherwise, it's useless, it just check the codeowners file from the latest commit in master
16+
17+
18+
jobs:
19+
validate-codeowners:
20+
name: Check that the CODEOWNERS is valid
21+
runs-on: ubuntu-latest
22+
steps:
23+
- uses: actions/checkout@v2
24+
- uses: actions/setup-python@v1
25+
with:
26+
python-version: 3.7
27+
- run: pip install pygithub click
28+
- name: Check that the CODEOWNERS is valid
29+
env:
30+
BOT_TOKEN: ${{ secrets.BOT_TOKEN }}
31+
run: python .github/workflows/notify_codeowners.py

0 commit comments

Comments
 (0)