feat: Add option to specify metric transformation unit (#49)

Co-authored-by: Duleendra Shashimal <duleendra@bambu.co>
Co-authored-by: Anton Babenko <anton@antonbabenko.com>

Author: 3 people

modules/log-metric-filter/README.md

@@ -33,6 +33,7 @@ No modules.
 | <a name="input_metric_transformation_default_value"></a> [metric\_transformation\_default\_value](#input\_metric\_transformation\_default\_value) | The value to emit when a filter pattern does not match a log event. | `string` | `null` | no |
 | <a name="input_metric_transformation_name"></a> [metric\_transformation\_name](#input\_metric\_transformation\_name) | The name of the CloudWatch metric to which the monitored log information should be published (e.g. ErrorCount) | `string` | n/a | yes |
 | <a name="input_metric_transformation_namespace"></a> [metric\_transformation\_namespace](#input\_metric\_transformation\_namespace) | The destination namespace of the CloudWatch metric. | `string` | n/a | yes |
+| <a name="input_metric_transformation_unit"></a> [metric\_transformation\_unit](#input\_metric\_transformation\_unit) | The unit to assign to the metric. If you omit this, the unit is set as None. | `string` | `null` | no |
 | <a name="input_metric_transformation_value"></a> [metric\_transformation\_value](#input\_metric\_transformation\_value) | What to publish to the metric. For example, if you're counting the occurrences of a particular term like 'Error', the value will be '1' for each occurrence. If you're counting the bytes transferred the published value will be the value in the log event. | `string` | `"1"` | no |
 | <a name="input_name"></a> [name](#input\_name) | A name for the metric filter. | `string` | n/a | yes |
 | <a name="input_pattern"></a> [pattern](#input\_pattern) | A valid CloudWatch Logs filter pattern for extracting metric data out of ingested log events. | `string` | n/a | yes |

modules/log-metric-filter/main.tf

@@ -10,5 +10,6 @@ resource "aws_cloudwatch_log_metric_filter" "this" {
     namespace     = var.metric_transformation_namespace
     value         = var.metric_transformation_value
     default_value = var.metric_transformation_default_value
+    unit          = var.metric_transformation_unit
   }
 }

modules/log-metric-filter/variables.tf

@@ -41,3 +41,9 @@ variable "metric_transformation_default_value" {
   type        = string
   default     = null
 }
+
+variable "metric_transformation_unit" {
+  description = "The unit to assign to the metric. If you omit this, the unit is set as None."
+  type        = string
+  default     = null
+}

wrappers/log-metric-filter/main.tf

@@ -11,4 +11,5 @@ module "wrapper" {
   metric_transformation_namespace     = try(each.value.metric_transformation_namespace, var.defaults.metric_transformation_namespace)
   metric_transformation_value         = try(each.value.metric_transformation_value, var.defaults.metric_transformation_value, "1")
   metric_transformation_default_value = try(each.value.metric_transformation_default_value, var.defaults.metric_transformation_default_value, null)
+  metric_transformation_unit          = try(each.value.metric_transformation_unit, var.defaults.metric_transformation_unit, null)
 }