Skip to content

Commit 02be86a

Browse files
authored
test: IgnoreUpdates for job module (#29)
1 parent 91f9c13 commit 02be86a

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ Currently, IBM provider supports basic functionalities, such as create/delete/up
5050
Known limitations are:
5151
- No support to create/delete/update code engine functions. https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5230
5252
- No support to create/delete/update code engine subscriptions. https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5231
53-
- Apply twice keeps on showing changes for `ibm_code_engine_app` terraform resource https://github.com/IBM-Cloud/terraform-provider-ibm/issues/4719
53+
- Apply twice keeps on showing changes for `ibm_code_engine_app` and `ibm_code_engine_job` terraform resource https://github.com/IBM-Cloud/terraform-provider-ibm/issues/4719
5454
- CLI/API service binding implementation/interface is different from terraform implementation. For example, CLI or UI code engine has a support to create access secret, service credential and all bindings automatically, while `code_engine_binding_instance` terraform resource requires that access secret exists before the binding is created. The second discrepancy between implementations is that terraform `code_engine_binding_instance` terraform resource requires `prefix` while using CLI or UI `prefix` is an optional parameter. https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5229
5555
- Visibility for application can not be set. While CLI uses `--visibility=private` flag to set the visibility, terraform provider doesn't support it. https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5228
5656
- Apply twice throwns an error for `ibm_code_engine_secret` terraform resource https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5232

tests/pr_test.go

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ func setupAppsExampleOptions(t *testing.T, prefix string, terraformDir string) *
4141
Prefix: prefix,
4242
ResourceGroup: resourceGroup,
4343
})
44+
// need to ignore because of a provider issue: https://github.com/IBM-Cloud/terraform-provider-ibm/issues/4719
4445
options.IgnoreUpdates = testhelper.Exemptions{
4546
List: []string{
4647
"module.code_engine.module.app[\"" + options.Prefix + "-app\"].ibm_code_engine_app.ce_app",
@@ -66,6 +67,13 @@ func setupJobsExampleOptions(t *testing.T, prefix string, terraformDir string) *
6667
Prefix: prefix,
6768
ResourceGroup: resourceGroup,
6869
})
70+
// need to ignore because of a provider issue: https://github.com/IBM-Cloud/terraform-provider-ibm/issues/4719
71+
options.IgnoreUpdates = testhelper.Exemptions{
72+
List: []string{
73+
"module.code_engine.module.job[\"" + options.Prefix + "-job\"].ibm_code_engine_job.ce_job",
74+
"module.code_engine.module.job[\"" + options.Prefix + "-job-2\"].ibm_code_engine_job.ce_job",
75+
},
76+
}
6977
options.TerraformVars = map[string]interface{}{
7078
"resource_group": resourceGroup,
7179
"prefix": options.Prefix,
@@ -142,7 +150,7 @@ func TestRunUpgradeAppSolution(t *testing.T) {
142150
Prefix: "ce-app-upg",
143151
ResourceGroup: resourceGroup,
144152
})
145-
153+
// need to ignore because of a provider issue: https://github.com/IBM-Cloud/terraform-provider-ibm/issues/4719
146154
options.IgnoreUpdates = testhelper.Exemptions{
147155
List: []string{
148156
"module.code_engine.module.app[\"" + options.Prefix + "-app\"].ibm_code_engine_app.ce_app",

0 commit comments

Comments
 (0)