Fix CID 1534939 (COPY_INSTEAD_OF_MOVE)

stweil · stweil · commit 3fedc6cdfc67 · 2024-11-10T11:21:04.000+01:00
Signed-off-by: Stefan Weil &lt;sw@weilnetz.de&gt;
diff --git a/src/ccstruct/blamer.cpp b/src/ccstruct/blamer.cpp
@@ -92,7 +92,7 @@ void BlamerBundle::SetSymbolTruth(const UNICHARSET &unicharset, const char *char
   if (id != INVALID_UNICHAR_ID) {
     std::string normed_uch(unicharset.get_normed_unichar(id));
     if (normed_uch.length() > 0) {
-      symbol_str = normed_uch;
+      symbol_str = std::move(normed_uch);
     }
   }
   int length = truth_word_.length();

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ void BlamerBundle::SetSymbolTruth(const UNICHARSET &unicharset, const char *char`
`92`	`92`	`if (id != INVALID_UNICHAR_ID) {`
`93`	`93`	`std::string normed_uch(unicharset.get_normed_unichar(id));`
`94`	`94`	`if (normed_uch.length() > 0) {`
`95`		`- symbol_str = normed_uch;`
	`95`	`+ symbol_str = std::move(normed_uch);`
`96`	`96`	`}`
`97`	`97`	`}`
`98`	`98`	`int length = truth_word_.length();`