feat: finalize sepay

Author: imrim12

app/utils/i18n.ts

@@ -1,3 +1,9 @@
+/**
+ * A safe useI18n that have mocked fallbacks in case the app context is not available.
+ *
+ * Do not use this widely in the project, only in some plugins, auto-imports that potentially do not
+ * have the app context like in notifications, $api, etc.
+ */
 export function useSafeI18n() {
   const nuxtApp = useNuxtApp()
 

package.json

@@ -1,7 +1,7 @@
 {
   "name": "@thecodeorigin/nuxt",
   "type": "module",
-  "version": "2.5.6",
+  "version": "2.6.0",
   "publishConfig": {
     "registry": "https://registry.npmjs.org",
     "access": "public"
@@ -97,6 +97,7 @@
     "firebase-admin": "^13.2.0",
     "lodash-es": "^4.17.21",
     "mongodb": "^6.14.2",
+    "nanoid": "^5.1.5",
     "nodemailer": "^6.10.0",
     "nuxt": "^3.16.0",
     "nuxt-gtag": "^3.0.2",

pnpm-lock.yaml

@@ -6,22 +6,21 @@ export default defineEventHandler(async (event) => {
   try {
     await defineEventOptions(event, { auth: true })
 
-    // description must be in format: uuid.uuid
-
     const { description } = await getValidatedQuery(
       event,
       query => z.object({
         description: z.string().min(1, 'Payment description must be in the correct format!'),
       })
         .refine((query) => {
-          const [part1, part2] = query.description.split('.')
+          const orderCode = query.description.slice(2)
 
-          return isUUID(part1) && isUUID(part2)
+          return orderCode.length === 16
         }, { message: 'Payment description must be in the correct format!' })
         .parse(query),
     )
 
-    const [orderCode] = description.split('.')
+    // remove the first 2 letters
+    const orderCode = description.slice(2)
 
     const { getProviderTransactionByOrderCode } = usePayment()
 

server/api/payments/sepay/status.get.ts

@@ -32,7 +32,7 @@ export default defineEventHandler(async (event) => {
         transactionDate: z.string(),
         transferAmount: z.number(),
         transferType: z.string(),
-      }).partial().parse(payload),
+      }).parse(payload),
     )
 
     if (process.env.SEPAY_WEBHOOK_SIGNING_KEY !== getHeader(event, 'Authorization')?.match(/Apikey (.*)/)?.[1]) {
@@ -48,17 +48,18 @@ export default defineEventHandler(async (event) => {
     // SePay Webhook always success (if not, it will not call this endpoint anyway)
 
     const transactionStatus = PaymentStatus.RESOLVED
+    const orderCode = body.code.slice(2) || '' // Remove the first 2 characters (SP)
 
     const { updatePaymentStatus, updateProviderTransactionStatus, getProviderTransactionByOrderCode } = usePayment()
 
-    const paymentTransactionOfProvider = await getProviderTransactionByOrderCode(String(body.code))
+    const paymentTransactionOfProvider = await getProviderTransactionByOrderCode(String(orderCode))
 
     if (!paymentTransactionOfProvider?.payment.order.package) {
-      logger.warn(`[SePay Webhook] Transaction not found or invalid: code=${body.code}`)
+      logger.warn(`[SePay Webhook] Transaction not found or invalid: code=${orderCode}`)
       return { success: true }
     }
 
-    logger.log(`[SePay Webhook] Processing transaction: code=${body.code}, status=${transactionStatus}`)
+    logger.log(`[SePay Webhook] Processing transaction: code=${orderCode}, status=${transactionStatus}`)
 
     const priceDiscount = Number(paymentTransactionOfProvider.payment.order.package.price_discount)
     const price = Number(paymentTransactionOfProvider.payment.order.package.price)
@@ -84,7 +85,7 @@ export default defineEventHandler(async (event) => {
     logger.log(`[SePay Webhook] Credits added successfully: userId=${userId}, amount=${creditAmount}`)
 
     if (!paymentTransactionOfProvider?.payment.order.package) {
-      logger.error(`[SePay Webhook] No product found for transaction: ${body.code}`)
+      logger.error(`[SePay Webhook] No product found for transaction: ${orderCode}`)
       throw createError({
         statusCode: 400,
         message: 'No product found for this transaction!',

server/api/payments/sepay/webhook.post.ts

@@ -1,6 +1,5 @@
 import type { User } from '@base/server/types/models'
-import { v4 as uuid } from 'uuid'
-import { createPayOSCheckout } from './payos'
+import { customAlphabet, nanoid } from 'nanoid'
 
 export * from './payos'
 
@@ -53,9 +52,10 @@ export async function createPaymentCheckout(
     Number(productInfo.price_discount || productInfo.price),
   )
 
-  const orderCode = uuid()
+  // exclude underscore _
+  const orderCode = customAlphabet('ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789', 16)()
 
-  const paymentProviderTransaction = await createProviderTransaction(
+  await createProviderTransaction(
     userPayment.id,
     payload.user.id,
     orderCode,
@@ -77,7 +77,6 @@ export async function createPaymentCheckout(
       return await createSePayCheckout({
         orderCode,
         amount: userPayment.amount,
-        paymentProviderTransaction,
       })
 
     default:

server/utils/payment/vn/index.ts

@@ -1,22 +1,28 @@
-import type { paymentProviderTransactionTable } from '@base/server/db/schemas'
 import { withQuery } from 'ufo'
 
 interface SePayCheckoutProps {
   orderCode: string
   amount: number
-  paymentProviderTransaction: typeof paymentProviderTransactionTable.$inferSelect
 }
 
 export async function createSePayCheckout({
   orderCode,
   amount,
-  paymentProviderTransaction,
 }: SePayCheckoutProps) {
+  const prefix = process.env.SEPAY_TRANSACTION_PREFIX || 'SP'
+
+  if (prefix.length !== 2) {
+    throw createError({
+      statusCode: 400,
+      statusMessage: 'Transaction prefix must be exactly 2 characters long.',
+    })
+  }
+
   return withQuery('https://qr.sepay.vn/img', {
     acc: process.env.SEPAY_BANK_NUMBER,
     bank: process.env.SEPAY_BANK_NAME,
     amount,
-    des: [orderCode, paymentProviderTransaction.provider_transaction_info].join('.'),
+    des: [prefix, orderCode].join(''),
     template: 'compact',
     download: false,
   })