Skip to content

Commit 922ce67

Browse files
author
Rob Emanuele
committed
Add domains to the puppet API
1 parent 1c52729 commit 922ce67

File tree

4 files changed

+146
-0
lines changed

4 files changed

+146
-0
lines changed
Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
Puppet::Type.type(:foreman_domain).provide(:rest_v3, :parent => Puppet::Type.type(:foreman_resource).provider(:rest_v3)) do
2+
confine :feature => [:json, :oauth]
3+
4+
def exists?
5+
!id.nil?
6+
end
7+
8+
def create
9+
path = "api/v2/domains"
10+
payload = {
11+
:domain => {
12+
:name => resource[:name],
13+
:fullname => resource[:fullname],
14+
}
15+
}
16+
req = request(:post, path, {}, payload.to_json)
17+
18+
unless success?(req)
19+
error_string = "Error making POST request to Foreman at #{request_uri(path)}: #{error_message(req)}"
20+
raise Puppet::Error.new(error_string)
21+
end
22+
end
23+
24+
def destroy
25+
req = request(:delete, destroy_path, {})
26+
27+
unless success?(req)
28+
error_string = "Error making DELETE request to Foreman at #{request_uri(path)}: #{error_message(req)}"
29+
raise Puppet::Error.new(error_string)
30+
end
31+
end
32+
33+
def id
34+
domain['id'] if domain
35+
end
36+
37+
def domain
38+
@domain ||= begin
39+
path = 'api/v2/domains'
40+
req = request(:get, path, :search => %{name="#{resource[:name]}"})
41+
42+
unless success?(req)
43+
error_string = "Error making GET request to Foreman at #{request_uri(path)}: #{error_message(req)}"
44+
raise Puppet::Error.new(error_string)
45+
end
46+
47+
JSON.load(req.body)['results'].first
48+
end
49+
end
50+
51+
private
52+
53+
def destroy_path
54+
"api/v2/domains/#{id}"
55+
end
56+
end

lib/puppet/type/foreman_domain.rb

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
require_relative '../../puppet_x/foreman/common'
2+
3+
Puppet::Type.newtype(:foreman_domain) do
4+
desc 'foreman_domain creates a domain in foreman.'
5+
6+
instance_eval(&PuppetX::Foreman::Common::REST_API_COMMON_PARAMS)
7+
instance_eval(&PuppetX::Foreman::Common::FOREMAN_DOMAIN_PARAMS)
8+
9+
end

lib/puppet_x/foreman/common.rb

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,16 @@ module Common
5656
desc 'The name of the host.'
5757
end
5858
end
59+
60+
FOREMAN_DOMAIN_PARAMS = Proc.new do
61+
newparam(:name, :namevar => true) do
62+
desc 'The name of the domain resource.'
63+
end
64+
65+
newparam(:fullname) do
66+
desc 'The name/description of the domain.'
67+
end
68+
end
5969
end
6070
end
6171
end
Lines changed: 71 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
1+
require 'spec_helper'
2+
3+
describe Puppet::Type.type(:foreman_domain).provider(:rest_v3) do
4+
let(:resource) do
5+
Puppet::Type.type(:foreman_domain).new(
6+
:name => 'example.com',
7+
:fullname => 'domain entry for example.com',
8+
:base_url => 'https://foreman.example.com',
9+
:consumer_key => 'oauth_key',
10+
:consumer_secret => 'oauth_secret',
11+
:effective_user => 'admin'
12+
)
13+
end
14+
15+
let(:provider) do
16+
provider = described_class.new
17+
provider.resource = resource
18+
provider
19+
end
20+
21+
describe '#create' do
22+
it 'sends POST request' do
23+
expect(provider).to receive(:request).with(:post, 'api/v2/domains', {}, kind_of(String)).and_return(
24+
double(:code => '201', :body => {'id' => 1, 'name' => 'example.com', 'fullname' => 'domain entry for example.com'})
25+
)
26+
provider.create
27+
end
28+
end
29+
30+
describe '#destroy' do
31+
it 'sends DELETE request' do
32+
expect(provider).to receive(:id).and_return(1)
33+
expect(provider).to receive(:request).with(:delete, 'api/v2/domains/1', {}).and_return(double(:code => '204'))
34+
provider.destroy
35+
end
36+
end
37+
38+
describe '#exists?' do
39+
it 'returns true when domain is marked as a foreman domain' do
40+
expect(provider).to receive(:domain).twice.and_return({"id" => 1})
41+
expect(provider.exists?).to be true
42+
end
43+
44+
it 'returns nil when domain does not exist' do
45+
expect(provider).to receive(:domain).and_return(nil)
46+
expect(provider.exists?).to be false
47+
end
48+
end
49+
50+
describe '#id' do
51+
it 'returns ID from domain hash' do
52+
expect(provider).to receive(:domain).twice.and_return({'id' => 1})
53+
expect(provider.id).to eq(1)
54+
end
55+
56+
it 'returns nil when domain is absent' do
57+
expect(provider).to receive(:domain).and_return(nil)
58+
expect(provider.id).to be_nil
59+
end
60+
end
61+
62+
describe '#domain' do
63+
it 'returns domain hash from API results' do
64+
expect(provider).to receive(:request).with(:get, 'api/v2/domains', :search => 'name="proxy.example.com"').and_return(
65+
double('response', :body => {:results => [{:id => 1, :name => 'proxy.example.com'}]}.to_json, :code => '200')
66+
)
67+
expect(provider.domain['id']).to eq(1)
68+
expect(provider.domain['name']).to eq('proxy.example.com')
69+
end
70+
end
71+
end

0 commit comments

Comments
 (0)