-
-
Notifications
You must be signed in to change notification settings - Fork 29
Open
Labels
debuggerRelated to the debugger packageRelated to the debugger packageenhancementNew feature or requestNew feature or request
Description
output from esbuild:
▲ [WARNING] Ignoring this import because "../../node_modules/@solid-devtools/debugger/dist/setup.js" was marked as having no side effects [ignored-bare-import]
src/Ingame.tsx:16:7:
16 │ import '@solid-devtools/debugger/setup';
╵ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"sideEffects" is false in the enclosing "package.json" file:
../../node_modules/@solid-devtools/debugger/package.json:17:2:
17 │ "sideEffects": false,
╵ ~~~~~~~~~~~~~
https://github.com/thetarnav/solid-devtools/blob/main/packages/debugger/src/setup.ts#L53
This looks like a side effect to me. You could either move this entire body of code into a "injectDevtools" function (I think this is what react does) or just mark the entire package as having side effects in the package.json.
EDIT: workaround: https://esbuild.github.io/api/#ignore-annotations
Metadata
Metadata
Assignees
Labels
debuggerRelated to the debugger packageRelated to the debugger packageenhancementNew feature or requestNew feature or request