Skip to content

Commit f49cddb

Browse files
committed
Change connection
1 parent 516e17e commit f49cddb

File tree

1 file changed

+35
-31
lines changed

1 file changed

+35
-31
lines changed

index.js

Lines changed: 35 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -11,20 +11,11 @@ var mssql = require('mssql');
1111
*/
1212
class MsSql {
1313

14-
constructor(pool, options) {
15-
14+
constructor(pool, params) {
1615
this.pool = pool;
17-
this.options = options;
16+
this.params = params;
1817
this.transaction = null;
1918
this._inTransaction = false;
20-
21-
var connectCallback = function connectCallback(err) {
22-
if (err) {
23-
throw err;
24-
}
25-
};
26-
27-
this.pool.connect(connectCallback);
2819
}
2920

3021
/**
@@ -93,26 +84,39 @@ class MsSql {
9384
}
9485

9586
module.exports = {
96-
open: function(connection, options) {
97-
98-
if ('string' === typeof connection) {
99-
return new MsSql(mssql.connect(connection), options);
87+
open: function(connection) {
88+
89+
try { // avoid warnings
90+
(async function openAsync(connection) {
91+
92+
if ('string' === typeof connection) {
93+
return new MsSql(await mssql.connect(connection));
94+
}
95+
96+
var convertedConnection = {
97+
server: connection.Hostname || 'localhost',
98+
port: parseInt(connection.Port) || 1433,
99+
database: connection.Database,
100+
user: connection.Username,
101+
password: connection.Password,
102+
options: connection.options || {}
103+
};
104+
105+
var config = Object.assign(
106+
{
107+
options: {
108+
abortTransactionOnError: true,
109+
encrypt: false
110+
}
111+
},
112+
convertedConnection
113+
);
114+
115+
return new MsSql(await mssql.connect(config));
116+
})(connection);
117+
118+
} catch ( err ) {
119+
throw err; // rethrow
100120
}
101-
102-
var config = {
103-
server: connection.Hostname || 'localhost',
104-
port: parseInt(connection.Port) || 1433,
105-
database: connection.Database,
106-
user: connection.Username,
107-
password: connection.Password,
108-
options: {
109-
abortTransactionOnError: true,
110-
encrypt: false
111-
}
112-
};
113-
114-
config.options = Object.assign(config.options, options || {});
115-
var pool = mssql.connect(config);
116-
return new MsSql(pool, config);
117121
}
118122
};

0 commit comments

Comments
 (0)