Skip to content

Commit 87bb8b5

Browse files
authored
fix characters with too many deaths cause crash (#272)
fix #271
1 parent 3602f04 commit 87bb8b5

File tree

3 files changed

+806
-0
lines changed

3 files changed

+806
-0
lines changed

src/TibiaCharactersCharacter.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -387,6 +387,10 @@ func TibiaCharactersCharacterImpl(BoxContentHTML string) (CharacterResponse, err
387387

388388
dataNoTags := RemoveHtmlTag(CharacterListHTML)
389389

390+
if strings.HasPrefix(dataNoTags, "There happened more character deaths in the last 30 days than we can display here.") {
391+
return false
392+
}
393+
390394
// defining responses
391395
DeathKillers := []Killers{}
392396
DeathAssists := []Killers{}

src/TibiaCharactersCharacter_test.go

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3115,6 +3115,30 @@ func TestNumber11(t *testing.T) {
31153115

31163116
}
31173117

3118+
func TestNumber12(t *testing.T) {
3119+
file, err := static.TestFiles.Open("testdata/characters/Stalone Matador.html")
3120+
if err != nil {
3121+
t.Fatalf("file opening error: %s", err)
3122+
}
3123+
defer file.Close()
3124+
3125+
data, err := io.ReadAll(file)
3126+
if err != nil {
3127+
t.Fatalf("File reading error: %s", err)
3128+
}
3129+
3130+
characterJson, err := TibiaCharactersCharacterImpl(string(data))
3131+
if err != nil {
3132+
t.Fatal(err)
3133+
}
3134+
3135+
assert := assert.New(t)
3136+
character := characterJson.Character.CharacterInfo
3137+
3138+
assert.Equal("Stalone Matador", character.Name)
3139+
assert.Equal(55, len(characterJson.Character.Deaths))
3140+
}
3141+
31183142
func BenchmarkNumber1(b *testing.B) {
31193143
file, err := static.TestFiles.Open("testdata/characters/Darkside Rafa.html")
31203144
if err != nil {

0 commit comments

Comments
 (0)