Skip to content

Remove temporary actionlint ignore for create-github-app-token client-id #34

@wuhuizuo

Description

@wuhuizuo

Summary

We added a temporary actionlint ignore for actions/create-github-app-token@v3 in .github/actionlint.yaml to suppress two false positives around the client-id input.

Background

PR #32 switched the Homebrew token workflow from the deprecated app-id input to client-id.

The workflow itself is valid, and GitHub Actions accepts it. However, the current reviewdog/action-actionlint@v1 release still reports these false positives because the bundled actionlint metadata for actions/create-github-app-token@v3 is stale:

  • missing input "app-id" which is required by action "actions/create-github-app-token@v3"
  • input "client-id" is not defined in action "actions/create-github-app-token@v3"

At the time of the workaround:

  • reviewdog/action-actionlint latest release: v1.72.0
  • bundled actionlint: v1.7.12
  • upstream action metadata already supports client-id

Current workaround

We added a narrow repository-local ignore in .github/actionlint.yaml that only suppresses the two exact false-positive messages for .github/workflows/release.yml.

This is intentionally scoped as tightly as possible and should be removed once upstream releases a fix.

Upstream references

Removal criteria

Remove the temporary ignore after both conditions are true:

  1. a released actionlint version includes updated metadata for actions/create-github-app-token@v3
  2. reviewdog/action-actionlint consumes that fixed actionlint release

Follow-up

When upstream is fixed:

  • delete the temporary entries from .github/actionlint.yaml
  • rerun PR Assistant to confirm the false positives no longer appear

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions