feat: Create database in a subdirectory of tempdir() by default

krlmlr · krlmlr · commit bd31e4543411 · 2025-02-01T06:25:48.000+01:00
diff --git a/R/relational-duckdb.R b/R/relational-duckdb.R
@@ -65,8 +65,9 @@ duckplyr_macros <- c(
 )
 
 create_default_duckdb_connection <- function() {
-  dbroot <- Sys.getenv("DUCKPLYR_TEMP_DIR", tempdir())
+  dbroot <- Sys.getenv("DUCKPLYR_TEMP_DIR", file.path(tempdir(), "duckplyr"))
   dbdir <- tempfile("duckplyr", tmpdir = dbroot, fileext = ".duckdb")
+  dir.create(dbroot, recursive = TRUE, showWarnings = FALSE)
 
   drv <- duckdb::duckdb(dbdir = dbdir)
   con <- DBI::dbConnect(drv)

Original file line number	Diff line number	Diff line change
`@@ -65,8 +65,9 @@ duckplyr_macros <- c(`
`65`	`65`	`)`
`66`	`66`
`67`	`67`	`create_default_duckdb_connection <- function() {`
`68`		`- dbroot <- Sys.getenv("DUCKPLYR_TEMP_DIR", tempdir())`
	`68`	`+ dbroot <- Sys.getenv("DUCKPLYR_TEMP_DIR", file.path(tempdir(), "duckplyr"))`
`69`	`69`	`dbdir <- tempfile("duckplyr", tmpdir = dbroot, fileext = ".duckdb")`
	`70`	`+ dir.create(dbroot, recursive = TRUE, showWarnings = FALSE)`
`70`	`71`
`71`	`72`	`drv <- duckdb::duckdb(dbdir = dbdir)`
`72`	`73`	`con <- DBI::dbConnect(drv)`