File tree Expand file tree Collapse file tree 1 file changed +27
-1
lines changed
Expand file tree Collapse file tree 1 file changed +27
-1
lines changed Original file line number Diff line number Diff line change 11This is a resubmission.
22
33Original submission: 2018-10-18
4- CRAN Review: 2019-10-22
4+ First CRAN Review: 2019-10-22
5+
6+ Second submission: 2019-10-22
7+ Second CRAN Review: 2019-10-28
8+
9+ The second reviewer brings up new things:
10+
11+ > Please add small files needed for the examples in the inst/extdata
12+ > subfolder of your package and use system.file() to get the correct
13+ > package path. e.g. sheets_auth_configure.Rd
14+ >
15+ > \dontrun{} should be only used if the example really cannot be executed
16+ > (e.g. because of missing additional software, missing API keys, ...) by
17+ > the user. That's why wrapping examples in \dontrun{} adds the comment
18+ > ("# Not run:") as a warning for the user.
19+ > Does not seem necessary.
20+ > Please replace \dontrun with \donttest.
21+
22+ I have added the requested file, below inst/extdata/, even though it must be
23+ filled with fake data. We cannot ship an actual OAuth client ID and secret
24+ inside a CRAN package this way. As documented for sheets_auth_configure(), the
25+ user has to obtain this JSON for themselves from Google Cloud Platform Console.
26+ But this JSON has valid structure and eliminates a \dontrun{}.
27+
28+ ---
29+
30+ Response to the first review:
531
632The reviewer asked for more details in the description and to explain all acronyms. I have added:
733
You can’t perform that action at this time.
0 commit comments