|
1 | | -This is a resubmission. |
2 | | - |
3 | | -Original submission: 2018-10-18 |
4 | | -First CRAN Review: 2019-10-22 |
5 | | - |
6 | | -Second submission: 2019-10-22 |
7 | | -Second CRAN Review: 2019-10-28 |
8 | | - |
9 | | -The second reviewer brings up new things: |
10 | | - |
11 | | -> Please add small files needed for the examples in the inst/extdata |
12 | | -> subfolder of your package and use system.file() to get the correct |
13 | | -> package path. e.g. sheets_auth_configure.Rd |
14 | | -> |
15 | | -> \dontrun{} should be only used if the example really cannot be executed |
16 | | -> (e.g. because of missing additional software, missing API keys, ...) by |
17 | | -> the user. That's why wrapping examples in \dontrun{} adds the comment |
18 | | -> ("# Not run:") as a warning for the user. |
19 | | -> Does not seem necessary. |
20 | | -> Please replace \dontrun with \donttest. |
21 | | -
|
22 | | -I have added the requested file, below inst/extdata/, even though it must be |
23 | | -filled with fake data. We cannot ship an actual OAuth client ID and secret |
24 | | -inside a CRAN package this way. As documented for sheets_auth_configure(), the |
25 | | -user has to obtain this JSON for themselves from Google Cloud Platform Console. |
26 | | -But this JSON has valid structure and eliminates a \dontrun{}. |
27 | | - |
28 | | ---- |
29 | | - |
30 | | -Response to the first review: |
31 | | - |
32 | | -The reviewer asked for more details in the description and to explain all acronyms. I have added: |
33 | | - |
34 | | - * An explanation that API = "application programming interface" and a |
35 | | - description of what that means. |
36 | | - * An explanation that v4 = "version 4" of the Sheets API. |
37 | | - * A statement that googlesheets4 lets a user retrieve metadata and data |
38 | | - out of a Google Sheet. |
39 | | - |
40 | | -## Test environments |
41 | | - |
42 | | -* local macOS 10.14 Mojave, R 3.6.0 |
43 | | -* local Windows 10 VM, R 3.6.0 |
44 | | -* win-builder (devel) |
45 | | -* Windows Server 2008 R2 SP1, R-devel, 32/64 bit, r-hub |
46 | | -* Windows Server 2012 R2 x64 (on appveyor), R 3.6.1 Patched |
47 | | -* Ubuntu 16.04 (on travis-ci), R devel through 3.2 |
48 | | -* Ubuntu Linux 16.04 LTS, R-release, GCC on r-hub |
49 | | -* Fedora Linux, R-devel, clang, gfortran on r-hub |
50 | | - |
51 | | -## R CMD check results |
52 | | - |
53 | | -0 errors | 0 warnings | 1 note |
54 | | - |
55 | | -* This is a new submission. |
| 1 | +This is small patch release to update a test fixture in anticipation of the |
| 2 | +release of tibble. It also includes an updated internal data object, reflecting |
| 3 | +the Sheets v4 API surface as of today. |
0 commit comments