From d7960c78cea9ad75802963cfb9074b76fcffa926 Mon Sep 17 00:00:00 2001 From: Cliff Date: Mon, 1 Jun 2026 18:02:03 +0000 Subject: [PATCH] fix(acp): make send_error available in release builds MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The thread goal handler added in #491 calls self.send_error() in a non-debug code path, but send_error was gated behind #[cfg(debug_assertions)], so it was compiled out of release builds. CI never caught this because every check builds and tests with the ci-test profile (which inherits from `test`, debug-assertions on), so the method exists there. Only `cargo build --release` in the release workflow compiles with debug-assertions off, where the method is absent and the call fails to compile with E0599. Remove the cfg gate so send_error exists in all builds. 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori --- nori-rs/acp/src/backend/submit_and_ops.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/nori-rs/acp/src/backend/submit_and_ops.rs b/nori-rs/acp/src/backend/submit_and_ops.rs index b7d90cd78..e65d5fc2a 100644 --- a/nori-rs/acp/src/backend/submit_and_ops.rs +++ b/nori-rs/acp/src/backend/submit_and_ops.rs @@ -293,8 +293,7 @@ impl AcpBackend { Ok(()) } - /// Send an error event to the TUI (only used in debug builds). - #[cfg(debug_assertions)] + /// Send an error event to the TUI. pub(super) async fn send_error(&self, message: &str) { let _ = self .event_tx