-
Notifications
You must be signed in to change notification settings - Fork 85
Description
Isn't the current attempt missing when executing this callback right here?
node-retry/lib/retry_operation.js
Line 110 in b8e26ea
| self._operationTimeoutCb(); |
I also found this line which confuses me. The readme says nothing about an option called forever in the timeouts function and I'm unsure if it's a miss in the readme or in the code.
Line 37 in b8e26ea
| if (options && options.forever && !timeouts.length) { |
https://github.com/tim-kos/node-retry#retrytimeoutsoptions
The timeout variable is used as the timeout in a setTimeout but this line right here sets timeout to an array of size 1 but setTimeout doesn't accept an array as a second argument.
node-retry/lib/retry_operation.js
Line 65 in b8e26ea
| timeout = this._cachedTimeouts.slice(-1); |
node-retry/lib/retry_operation.js
Line 86 in b8e26ea
| }, timeout); |
Couldn't this cause unwanted behaviour?